Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2174983002: OS_LINUX and OS_ANDROID are mutually exclusive. (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
4 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, Dirk Pranke, phoglund_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OS_LINUX and OS_ANDROID are mutually exclusive. Remove ifdefs that assume otherwise. Committed: https://crrev.com/a9a3185d4836f31adfe52314cbf8724345b43c88 Cr-Commit-Position: refs/heads/master@{#407541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M services/shell/runner/host/child_process_base.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M services/shell/runner/host/child_process_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/aura_init.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/aura_init.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Lei Zhang
4 years, 5 months ago (2016-07-22 22:51:59 UTC) #5
sky
LGTM
4 years, 5 months ago (2016-07-22 23:50:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174983002/1
4 years, 5 months ago (2016-07-25 17:23:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 19:13:28 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 19:15:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9a3185d4836f31adfe52314cbf8724345b43c88
Cr-Commit-Position: refs/heads/master@{#407541}

Powered by Google App Engine
This is Rietveld 408576698