chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm - Issue 2174973002: [Mac][MD User Menu] Revamped signin/sync error surfacing UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm

Issue 2174973002: [Mac][MD User Menu] Revamped signin/sync error surfacing UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: After refactoring Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm ('k') | chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm b/chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm

index 1e3e7455d6ac286ec53afa43a249fe64d835d6a8..26572c6e2fb2308e3c3c8600457e1a52e9aa9fb6 100644

--- a/chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm

@@ -26,7 +26,7 @@

// Defined in the AvatarButtonController implementation.

@interface AvatarButtonController (ExposedForTesting)

-- (void)updateErrorStatus:(BOOL)hasError;

+- (void)setErrorStatus:(BOOL)hasError;

@end

// Subclassing AvatarButtonController to be able to control the state of

@@ -102,7 +102,7 @@ TEST_F(AvatarButtonControllerTest, ProfileButtonWithErrorShown) {

testing_profile_manager()->CreateTestingProfile("batman");

EXPECT_EQ(0, [button() image].size.width);

- [controller() updateErrorStatus:true];

+ [controller() setErrorStatus:true];

ASSERT_FALSE([view() isHidden]);

EXPECT_NSEQ(@"Person 1", [button() title]);