[Mac][MD User Menu] Revamped signin/sync error surfacing UI

chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/profiles/avatar_base_controller.h"
 
 #include "base/mac/foundation_util.h"
 #include "base/macros.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/browser_process.h"
-#include "chrome/browser/profiles/profile_attributes_storage.h"
 #include "chrome/browser/profiles/profile_avatar_icon_util.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/profiles/profile_metrics.h"
 #include "chrome/browser/profiles/profile_window.h"
 #include "chrome/browser/profiles/profiles_state.h"
 #include "chrome/browser/signin/chrome_signin_helper.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_window.h"
 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller.h"
 #import "chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h"
-#include "components/signin/core/browser/signin_error_controller.h"
 #include "components/signin/core/common/profile_management_switches.h"
 #include "ui/base/cocoa/cocoa_base_utils.h"
 
 // Space between the avatar icon and the avatar menu bubble.
 const CGFloat kMenuYOffsetAdjust = 1.0;
 // Offset needed to align the edge of the avatar bubble with the edge of the
 // avatar button.
 const CGFloat kMenuXOffsetAdjust = 2.0;
 
 @interface AvatarBaseController (Private)
 // Shows the avatar bubble.
 - (IBAction)buttonClicked:(id)sender;
 - (IBAction)buttonRightClicked:(id)sender;
 
 - (void)bubbleWillClose:(NSNotification*)notif;
 
 // Updates the profile name displayed by the avatar button. If |layoutParent| is
 // yes, then the BrowserWindowController is notified to relayout the subviews,
 // as the button needs to be repositioned.
 - (void)updateAvatarButtonAndLayoutParent:(BOOL)layoutParent;
 
 // Displays an error icon if any accounts associated with this profile have an
-// auth error.
-- (void)updateErrorStatus:(BOOL)hasError;
+// auth error or sync error.
+- (void)setErrorStatus:(BOOL)hasError;
 @end
 
-class ProfileAttributesUpdateObserver
-    : public ProfileAttributesStorage::Observer,
-      public SigninErrorController::Observer {
- public:
-  ProfileAttributesUpdateObserver(Profile* profile,
-                                  AvatarBaseController* avatarController)
-      : profile_(profile),
-        avatarController_(avatarController) {
-    g_browser_process->profile_manager()->
-        GetProfileAttributesStorage().AddObserver(this);
+ProfileUpdateObserver::ProfileUpdateObserver(
+    Profile* profile,
+    AvatarBaseController* avatarController)
+    : errorController_(this, profile),
+      profile_(profile),
+      avatarController_(avatarController) {
+  g_browser_process->profile_manager()
+      ->GetProfileAttributesStorage()
+      .AddObserver(this);
+}
 
-    // Subscribe to authentication error changes so that the avatar button
-    // can update itself.
-    SigninErrorController* errorController =
-        profiles::GetSigninErrorController(profile_);
-    if (errorController)
-      errorController->AddObserver(this);
-  }
+ProfileUpdateObserver::~ProfileUpdateObserver() {
+  g_browser_process->profile_manager()
+      ->GetProfileAttributesStorage()
+      .RemoveObserver(this);
+}
 
-  ~ProfileAttributesUpdateObserver() override {
-    g_browser_process->profile_manager()->
-        GetProfileAttributesStorage().RemoveObserver(this);
-    SigninErrorController* errorController =
-        profiles::GetSigninErrorController(profile_);
-    if (errorController)
-      errorController->RemoveObserver(this);
-  }
+void ProfileUpdateObserver::OnProfileAdded(const base::FilePath& profile_path) {
+  [avatarController_ updateAvatarButtonAndLayoutParent:YES];
+}
 
-  // ProfileAttributesStorage::Observer:
-  void OnProfileAdded(const base::FilePath& profile_path) override {
+void ProfileUpdateObserver::OnProfileWasRemoved(
+    const base::FilePath& profile_path,
+    const base::string16& profile_name) {
+  // If deleting the active profile, don't bother updating the avatar
+  // button, as the browser window is being closed anyway.
+  if (profile_->GetPath() != profile_path)
     [avatarController_ updateAvatarButtonAndLayoutParent:YES];
-  }
+}
 
-  void OnProfileWasRemoved(const base::FilePath& profile_path,
-                           const base::string16& profile_name) override {
-    // If deleting the active profile, don't bother updating the avatar
-    // button, as the browser window is being closed anyway.
-    if (profile_->GetPath() != profile_path)
-      [avatarController_ updateAvatarButtonAndLayoutParent:YES];
-  }
+void ProfileUpdateObserver::OnProfileNameChanged(
+    const base::FilePath& profile_path,
+    const base::string16& old_profile_name) {
+  if (profile_->GetPath() == profile_path)
+    [avatarController_ updateAvatarButtonAndLayoutParent:YES];
+}
 
-  void OnProfileNameChanged(const base::FilePath& profile_path,
-                            const base::string16& old_profile_name) override {
-    if (profile_->GetPath() == profile_path)
-      [avatarController_ updateAvatarButtonAndLayoutParent:YES];
-  }
+void ProfileUpdateObserver::OnProfileSupervisedUserIdChanged(
+    const base::FilePath& profile_path) {
+  if (profile_->GetPath() == profile_path)
+    [avatarController_ updateAvatarButtonAndLayoutParent:YES];
+}
 
-  void OnProfileSupervisedUserIdChanged(
-      const base::FilePath& profile_path) override {
-    if (profile_->GetPath() == profile_path)
-      [avatarController_ updateAvatarButtonAndLayoutParent:YES];
-  }
+void ProfileUpdateObserver::OnAvatarErrorChanged() {
+  [avatarController_ setErrorStatus:errorController_.HasAvatarError()];
+}
 
-  // SigninErrorController::Observer:
-  void OnErrorChanged() override {
-    SigninErrorController* errorController =
-        profiles::GetSigninErrorController(profile_);
-    if (errorController)
-      [avatarController_ updateErrorStatus:errorController->HasError()];
-  }
-
- private:
-  Profile* profile_;
-  AvatarBaseController* avatarController_;  // Weak; owns this.
-
-  DISALLOW_COPY_AND_ASSIGN(ProfileAttributesUpdateObserver);
-};
+bool ProfileUpdateObserver::HasAvatarError() {
+  return errorController_.HasAvatarError();
+}
 
 @implementation AvatarBaseController
 
 - (id)initWithBrowser:(Browser*)browser {
   if ((self = [super init])) {
     browser_ = browser;
-    profileAttributesObserver_.reset(
-        new ProfileAttributesUpdateObserver(browser_->profile(), self));
+    profileObserver_.reset(
+        new ProfileUpdateObserver(browser_->profile(), self));
   }
   return self;
 }
 
 - (void)dealloc {
   [self browserWillBeDestroyed];
   [super dealloc];
 }
 
 - (void)browserWillBeDestroyed {
@@ skipping 111 matching lines @@
     [static_cast<BrowserWindowController*>(wc)
         releaseBarVisibilityForOwner:self withAnimation:YES delay:NO];
   }
   menuController_ = nil;
 }
 
 - (void)updateAvatarButtonAndLayoutParent:(BOOL)layoutParent {
   NOTREACHED();
 }
 
-- (void)updateErrorStatus:(BOOL)hasError {
+- (void)setErrorStatus:(BOOL)hasError {
 }
 
 - (BaseBubbleController*)menuController {
   return menuController_;
 }
 
 @end