Issue 217493002: Add a compatibility symlink for the Google Chrome launcher script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 217493002: Add a compatibility symlink for the Google Chrome launcher script (Closed)

Created:
6 years, 8 months ago by Paweł Hajdan Jr.

Modified:
6 years, 8 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add a compatibility symlink for the Google Chrome launcher script BUG=351836 R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260274

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/installer/linux/common/installer.include	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Committed patchset #1 manually as r260274 (presubmit successful).

6 years, 8 months ago (2014-03-28 21:00:59 UTC) #2

Matt Giuca

6 years, 8 months ago (2014-03-28 22:08:25 UTC) #3

Message was sent while issue was closed.

Thanks for doing this.

One thing I would add (post-commit, maybe worthwhile in a follow up) is to add a
comment explaining why we need this symlink (for compatibility with existing
shortcuts), so this doesn't happen again. In fact, perhaps noting that if this
is ever renamed again, another compatibility shortcut should be made.

Expand Messages | Collapse Messages