Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 2174923002: bot_update: fix git dir check (Closed)

Created:
4 years, 5 months ago by nodir
Modified:
4 years, 5 months ago
Reviewers:
hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

bot_update: fix git dir check existance of a dir does not mean it is a git repo. Check .git dir presence instead. This is the reason why swarmbucket build.git builds fail. TBR=hinoka@chromium.org BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/cdac80c9fb4768bdc5bc42734e852e1f216224c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M recipe_modules/bot_update/resources/bot_update.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nodir
hinoka lgtmed it offline, so landing
4 years, 5 months ago (2016-07-22 19:03:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174923002/1
4 years, 5 months ago (2016-07-22 19:03:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/cdac80c9fb4768bdc5bc42734e852e1f216224c9
4 years, 5 months ago (2016-07-22 19:05:58 UTC) #5
nodir
4 years, 5 months ago (2016-07-22 22:48:59 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2173683003/ by nodir@chromium.org.

The reason for reverting is: this is wrong. if directory is not empty, git clone
fails.

Powered by Google App Engine
This is Rietveld 408576698