Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 2174883002: [Android] Root devices before asan_device_setup.sh. (Closed)

Created:
4 years, 5 months ago by jbudorick
Modified:
4 years, 5 months ago
Reviewers:
martiniss, xunjieli
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -20 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 chunk +18 lines, -15 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroidASan_tester.json View 4 chunks +80 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json View 4 chunks +56 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json View 2 chunks +48 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
jbudorick
TBR: narrow, again I think the only alternatives to this involve modifying asan_device_setup.sh itself, which ...
4 years, 5 months ago (2016-07-22 17:45:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174883002/1
4 years, 5 months ago (2016-07-22 17:45:56 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 17:49:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/ee1426a78d337cd4715a...

Powered by Google App Engine
This is Rietveld 408576698