third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js - Issue 2174863003: DevTools: traverse widget hierarchy to reveal views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

Issue 2174863003: DevTools: traverse widget hierarchy to reveal views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

index 354299b2eeeb71ca59ccfa4862ffb1841119259f..54ef09fb55f406912d4aa78330363c77411bfa0d 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

@@ -75,7 +75,7 @@ WebInspector.WatchExpressionsSidebarPane.prototype = {

addExpression: function(expressionString)

{

- this.requestReveal();

+ this.revealWidget();

if (this._requiresUpdate) {

this._rebuildWatchExpressions();

delete this._requiresUpdate;

@@ -87,7 +87,7 @@ WebInspector.WatchExpressionsSidebarPane.prototype = {

expandIfNecessary: function()

{

if (this._watchExpressionsSetting.get().length)

- this.requestReveal();

+ this.revealWidget();

_saveExpressions: function()

@@ -116,7 +116,7 @@ WebInspector.WatchExpressionsSidebarPane.prototype = {

{

if (event)

event.consume(true);

- this.requestReveal();

+ this.revealWidget();

this._createWatchExpression(null).startEditing();

@@ -134,7 +134,7 @@ WebInspector.WatchExpressionsSidebarPane.prototype = {

this._linkifier.reset();

this._bodyElement.removeChildren();

this._watchExpressions = [];

- this._emptyElement = this._bodyElement.createChild("div", "info");

+ this._emptyElement = this._bodyElement.createChild("div", "gray-info-message");

this._emptyElement.textContent = WebInspector.UIString("No Watch Expressions");

var watchExpressionStrings = this._watchExpressionsSetting.get();

for (var i = 0; i < watchExpressionStrings.length; ++i) {