Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js

Issue 2174863003: DevTools: traverse widget hierarchy to reveal views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lcean Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js
index 046eca1195e8d77c9fffdc0a7ca2c0cc1238a9a6..5b7d53c5286a8cdbcad6dd3f2564b5d42a5aa7dc 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js
@@ -10,7 +10,6 @@
WebInspector.ThreadsSidebarPane = function()
{
WebInspector.View.call(this, WebInspector.UIString("Threads"));
- this.requestSetVisible(false);
/** @type {!Map.<!WebInspector.DebuggerModel, !WebInspector.UIList.Item>} */
this._debuggerModelToListItems = new Map();
@@ -35,10 +34,8 @@ WebInspector.ThreadsSidebarPane.prototype = {
targetAdded: function(target)
{
var debuggerModel = WebInspector.DebuggerModel.fromTarget(target)
- if (!debuggerModel) {
- this._updateVisibility();
+ if (!debuggerModel)
return;
- }
var executionContext = target.runtimeModel.defaultExecutionContext();
var label = executionContext && executionContext.label() ? executionContext.label() : target.name();
@@ -52,13 +49,6 @@ WebInspector.ThreadsSidebarPane.prototype = {
this._listItemsToTargets.set(listItem, target);
this.threadList.addItem(listItem);
this._updateDebuggerState(debuggerModel);
- this._updateVisibility();
- },
-
- _updateVisibility: function()
- {
- this._wasVisibleAtLeastOnce = this._wasVisibleAtLeastOnce || this._debuggerModelToListItems.size > 1;
- this.requestSetVisible(this._wasVisibleAtLeastOnce);
},
/**
@@ -75,7 +65,6 @@ WebInspector.ThreadsSidebarPane.prototype = {
this._listItemsToTargets.remove(listItem);
this.threadList.removeItem(listItem);
}
- this._updateVisibility();
},
/**

Powered by Google App Engine
This is Rietveld 408576698