Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2174843002: Connect dst color space in a few places (removing TODOs) (Closed)

Created:
4 years, 5 months ago by Brian Osman
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Connect dst color space in a few places (removing TODOs) There is one more XFORMTODO left, but it requires more plumbing. With this change, certain drawing paths do gamut conversion with no special hacking required. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2174843002 Committed: https://skia.googlesource.com/skia/+/500bb3e3e47268fa271b0ac76e57a87379614a87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/gpu/GrTextureParamsAdjuster.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/GrTextureParamsAdjuster.cpp View 4 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice_drawTexture.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Brian Osman
4 years, 5 months ago (2016-07-22 14:53:37 UTC) #5
bsalomon
lgtm
4 years, 5 months ago (2016-07-22 17:25:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174843002/1
4 years, 5 months ago (2016-07-22 17:32:13 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 17:33:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/500bb3e3e47268fa271b0ac76e57a87379614a87

Powered by Google App Engine
This is Rietveld 408576698