third_party/WebKit/Source/core/svg/SVGUseElement.h - Issue 2174833002: Make fragment-only URLs always be document-local references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGUseElement.h

Issue 2174833002: Make fragment-only URLs always be document-local references (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove isExternal...; add additional test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGURIReference.cpp ('k') | third_party/WebKit/Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGUseElement.h

diff --git a/third_party/WebKit/Source/core/svg/SVGUseElement.h b/third_party/WebKit/Source/core/svg/SVGUseElement.h

index 26fe4b622f1cacbb5a0581aceecae82508aa4748..cd8332ae170115bafab348185a7ce7f7a8f1c840 100644

--- a/third_party/WebKit/Source/core/svg/SVGUseElement.h

+++ b/third_party/WebKit/Source/core/svg/SVGUseElement.h

@@ -73,7 +73,7 @@ private:

void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*) override;

bool isPresentationAttributeWithSVGDOM(const QualifiedName&) const override;

- bool isStructurallyExternal() const override { return !hrefString().isNull() && isExternalURIReference(hrefString(), document()); }

+ bool isStructurallyExternal() const override;

InsertionNotificationRequest insertedInto(ContainerNode*) override;

void removedFrom(ContainerNode*) override;

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGURIReference.cpp ('k') | third_party/WebKit/Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »