third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp - Issue 2174833002: Make fragment-only URLs always be document-local references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Issue 2174833002: Make fragment-only URLs always be document-local references (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove isExternal...; add additional test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp ('k') | third_party/WebKit/Source/core/svg/SVGURIReference.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

index bd5c532c1470f56bbd8ebc749d3d5b24f6b72abe..c1c4a2e78d007f9fc3cb09b7f82f1a394809c696 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

@@ -123,10 +123,9 @@ PassRefPtr<ClipPathOperation> StyleBuilderConverter::convertClipPath(StyleResolv

if (value.isBasicShapeValue())

return ShapeClipPathOperation::create(basicShapeForValue(state, value));

if (value.isURIValue()) {

- String cssURLValue = toCSSURIValue(value).value();

- KURL url = state.document().completeURL(cssURLValue);

+ SVGURLReferenceResolver resolver(toCSSURIValue(value).value(), state.document());

// TODO(fs): Doesn't work with forward or external SVG references (crbug.com/391604, crbug.com/109212, ...)

- return ReferenceClipPathOperation::create(cssURLValue, AtomicString(url.fragmentIdentifier()));

+ return ReferenceClipPathOperation::create(toCSSURIValue(value).value(), resolver.fragmentIdentifier());

}

DCHECK(value.isPrimitiveValue() && toCSSPrimitiveValue(value).getValueID() == CSSValueNone);

return nullptr;