Normalizing source file names before calculating hash

chrome/browser/metrics/metrics_log_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/metrics_log.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/basictypes.h"
@@ skipping 456 matching lines @@
 
 // Test that we properly write profiler data to the log.
 TEST_F(MetricsLogTest, RecordProfilerData) {
   TestMetricsLog log(kClientId, kSessionId);
   EXPECT_EQ(0, log.uma_proto().profiler_event_size());
 
   {
     ProcessDataSnapshot process_data;
     process_data.process_id = 177;
     process_data.tasks.push_back(TaskSnapshot());
-    process_data.tasks.back().birth.location.file_name = "file";
+    process_data.tasks.back().birth.location.file_name = "a/b/file.h";
     process_data.tasks.back().birth.location.function_name = "function";
     process_data.tasks.back().birth.location.line_number = 1337;
     process_data.tasks.back().birth.thread_name = "birth_thread";
     process_data.tasks.back().death_data.count = 37;
     process_data.tasks.back().death_data.run_duration_sum = 31;
     process_data.tasks.back().death_data.run_duration_max = 17;
     process_data.tasks.back().death_data.run_duration_sample = 13;
     process_data.tasks.back().death_data.queue_duration_sum = 8;
     process_data.tasks.back().death_data.queue_duration_max = 5;
     process_data.tasks.back().death_data.queue_duration_sample = 3;
     process_data.tasks.back().death_thread_name = "Still_Alive";
     process_data.tasks.push_back(TaskSnapshot());
-    process_data.tasks.back().birth.location.file_name = "file2";
+    process_data.tasks.back().birth.location.file_name = "c\\d\\file2";
     process_data.tasks.back().birth.location.function_name = "function2";
     process_data.tasks.back().birth.location.line_number = 1773;
     process_data.tasks.back().birth.thread_name = "birth_thread2";
     process_data.tasks.back().death_data.count = 19;
     process_data.tasks.back().death_data.run_duration_sum = 23;
     process_data.tasks.back().death_data.run_duration_max = 11;
     process_data.tasks.back().death_data.run_duration_sample = 7;
     process_data.tasks.back().death_data.queue_duration_sum = 0;
     process_data.tasks.back().death_data.queue_duration_max = 0;
     process_data.tasks.back().death_data.queue_duration_sample = 0;
     process_data.tasks.back().death_thread_name = "death_thread";
 
     log.RecordProfilerData(process_data, content::PROCESS_TYPE_BROWSER);
     ASSERT_EQ(1, log.uma_proto().profiler_event_size());
     EXPECT_EQ(ProfilerEventProto::STARTUP_PROFILE,
               log.uma_proto().profiler_event(0).profile_type());
     EXPECT_EQ(ProfilerEventProto::WALL_CLOCK_TIME,
               log.uma_proto().profiler_event(0).time_source());
 
     ASSERT_EQ(2, log.uma_proto().profiler_event(0).tracked_object_size());
 
     const ProfilerEventProto::TrackedObject* tracked_object =
         &log.uma_proto().profiler_event(0).tracked_object(0);
-    EXPECT_EQ(GG_UINT64_C(10123486280357988687),
+    EXPECT_EQ(GG_UINT64_C(5891889577137156145),
               tracked_object->source_file_name_hash());
     EXPECT_EQ(GG_UINT64_C(13962325592283560029),
               tracked_object->source_function_name_hash());
     EXPECT_EQ(1337, tracked_object->source_line_number());
     EXPECT_EQ(GG_UINT64_C(3400908935414830400),
               tracked_object->birth_thread_name_hash());
     EXPECT_EQ(37, tracked_object->exec_count());
     EXPECT_EQ(31, tracked_object->exec_time_total());
     EXPECT_EQ(13, tracked_object->exec_time_sampled());
     EXPECT_EQ(8, tracked_object->queue_time_total());
@@ skipping 33 matching lines @@
     process_data.tasks.back().birth.location.line_number = 7331;
     process_data.tasks.back().birth.thread_name = "birth_thread3";
     process_data.tasks.back().death_data.count = 137;
     process_data.tasks.back().death_data.run_duration_sum = 131;
     process_data.tasks.back().death_data.run_duration_max = 117;
     process_data.tasks.back().death_data.run_duration_sample = 113;
     process_data.tasks.back().death_data.queue_duration_sum = 108;
     process_data.tasks.back().death_data.queue_duration_max = 105;
     process_data.tasks.back().death_data.queue_duration_sample = 103;
     process_data.tasks.back().death_thread_name = "death_thread3";
+    process_data.tasks.push_back(TaskSnapshot());
+    process_data.tasks.back().birth.location.file_name = "";
+    process_data.tasks.back().birth.location.function_name = "";
+    process_data.tasks.back().birth.location.line_number = 7331;
+    process_data.tasks.back().birth.thread_name = "";
+    process_data.tasks.back().death_data.count = 137;
+    process_data.tasks.back().death_data.run_duration_sum = 131;
+    process_data.tasks.back().death_data.run_duration_max = 117;
+    process_data.tasks.back().death_data.run_duration_sample = 113;
+    process_data.tasks.back().death_data.queue_duration_sum = 108;
+    process_data.tasks.back().death_data.queue_duration_max = 105;
+    process_data.tasks.back().death_data.queue_duration_sample = 103;

[Ilya Sherman, 2014/03/29 01:06:49]

I would prefer if you did not repeat the constants from above here.  I
originally chose all of these constants to be unique.  IMO, it might even be
better to just write this as a separate test case, where you don't set any of
the numeric constants at all, and only verify that the names are hashed as you'd
expect.  (Assuming I'm correctly understanding the purpose of this test.)

[vadimt, 2014/03/31 18:10:14]

Yeah, I could add a separate test. But everything else is tested altogether, and
I'm not motivated to break this structure.
I've changed constants, though.

If you feel very strong about creating an additional test, please let me know.

+    process_data.tasks.back().death_thread_name = "";
 
     log.RecordProfilerData(process_data, content::PROCESS_TYPE_RENDERER);
     ASSERT_EQ(1, log.uma_proto().profiler_event_size());
     EXPECT_EQ(ProfilerEventProto::STARTUP_PROFILE,
               log.uma_proto().profiler_event(0).profile_type());
     EXPECT_EQ(ProfilerEventProto::WALL_CLOCK_TIME,
               log.uma_proto().profiler_event(0).time_source());
-    ASSERT_EQ(3, log.uma_proto().profiler_event(0).tracked_object_size());
+    ASSERT_EQ(4, log.uma_proto().profiler_event(0).tracked_object_size());
 
     const ProfilerEventProto::TrackedObject* tracked_object =
         &log.uma_proto().profiler_event(0).tracked_object(2);
     EXPECT_EQ(GG_UINT64_C(2686523203278102732),
               tracked_object->source_file_name_hash());
     EXPECT_EQ(GG_UINT64_C(5081672290546182009),
               tracked_object->source_function_name_hash());
     EXPECT_EQ(7331, tracked_object->source_line_number());
     EXPECT_EQ(GG_UINT64_C(1518842999910132863),
               tracked_object->birth_thread_name_hash());
     EXPECT_EQ(137, tracked_object->exec_count());
     EXPECT_EQ(131, tracked_object->exec_time_total());
     EXPECT_EQ(113, tracked_object->exec_time_sampled());
     EXPECT_EQ(108, tracked_object->queue_time_total());
     EXPECT_EQ(103, tracked_object->queue_time_sampled());
     EXPECT_EQ(GG_UINT64_C(2203893603452504755),
               tracked_object->exec_thread_name_hash());
     EXPECT_EQ(1177U, tracked_object->process_id());
     EXPECT_EQ(ProfilerEventProto::TrackedObject::RENDERER,
               tracked_object->process_type());
+
+    tracked_object = &log.uma_proto().profiler_event(0).tracked_object(3);
+    EXPECT_EQ(GG_UINT64_C(15284527576400310788),
+              tracked_object->source_file_name_hash());
+    EXPECT_EQ(GG_UINT64_C(15284527576400310788),
+              tracked_object->source_function_name_hash());
+    EXPECT_EQ(7331, tracked_object->source_line_number());
+    EXPECT_EQ(GG_UINT64_C(15284527576400310788),
+              tracked_object->birth_thread_name_hash());
+    EXPECT_EQ(137, tracked_object->exec_count());
+    EXPECT_EQ(131, tracked_object->exec_time_total());
+    EXPECT_EQ(113, tracked_object->exec_time_sampled());
+    EXPECT_EQ(108, tracked_object->queue_time_total());
+    EXPECT_EQ(103, tracked_object->queue_time_sampled());
+    EXPECT_EQ(GG_UINT64_C(15284527576400310788),
+              tracked_object->exec_thread_name_hash());
+    EXPECT_EQ(1177U, tracked_object->process_id());
+    EXPECT_EQ(ProfilerEventProto::TrackedObject::RENDERER,
+              tracked_object->process_type());
   }
 }
 
 #if defined(OS_CHROMEOS)
 TEST_F(MetricsLogTest, MultiProfileUserCount) {
   std::string user1("user1@example.com");
   std::string user2("user2@example.com");
   std::string user3("user3@example.com");
 
   // |scoped_enabler| takes over the lifetime of |user_manager|.
@@ skipping 121 matching lines @@
   PairedDevice device2 =
       log.system_profile().hardware().bluetooth().paired_device(1);
 
   EXPECT_EQ(FakeBluetoothDeviceClient::kConfirmPasskeyClass,
             device2.bluetooth_class());
   EXPECT_EQ(PairedDevice::DEVICE_PHONE, device2.type());
   EXPECT_EQ(0x207D74U, device2.vendor_prefix());
   EXPECT_EQ(PairedDevice::VENDOR_ID_UNKNOWN, device2.vendor_id_source());
 }
 #endif  // OS_CHROMEOS