Issue 2174823002: Fix flaky CredentialManagerBrowserTest.AutoSigninOldCredentialAndNavigation.

Issue 2174823002: Fix flaky CredentialManagerBrowserTest.AutoSigninOldCredentialAndNavigation. (Closed)

Created:
4 years, 5 months ago by vasilii

Modified:
4 years, 4 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix flaky CredentialManagerBrowserTest.AutoSigninOldCredentialAndNavigation. BUG=626759 Committed: https://crrev.com/6a1a34496fb2c897e91035d276ee6bf5ac475fbe Cr-Commit-Position: refs/heads/master@{#407438}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -12 lines)			Patch
	M	chrome/browser/password_manager/credential_manager_browsertest.cc	View		2 chunks	+9 lines, -12 lines	0 comments	Download

Total messages: 12 (7 generated)

vasilii

Hi Vaclav, please review the CL. It doesn't fix the Mac specific DCHECK but fixes ...

4 years, 5 months ago (2016-07-22 14:40:40 UTC) #4

vabr (Chromium)

LGTM, thanks for cleaning all the flakiness up, Vasilii! Vaclav

4 years, 5 months ago (2016-07-22 20:39:39 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174823002/1

4 years, 4 months ago (2016-07-25 08:57:44 UTC) #9

commit-bot: I haz the power

4 years, 4 months ago (2016-07-25 09:40:25 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6a1a34496fb2c897e91035d276ee6bf5ac475fbe
Cr-Commit-Position: refs/heads/master@{#407438}