Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2174813003: Don't resolve non-local -webkit-clip-path references as local (Closed)

Created:
4 years, 5 months ago by fs
Modified:
4 years, 5 months ago
Reviewers:
pdr., Stephen Chennney
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-local-references
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't resolve non-local -webkit-clip-path references as local Whether the reference was local or not was disregarded, meaning that any URL with a valid fragment part could potential result in a valid clip - regardless of whether it was local or not. I.e foo.svg#bar would reference an element with the id 'bar' in the local document. Check if the URL reference resolver flagged the reference as being local, and only pass a non-null fragment if it was. BUG=629826 Committed: https://crrev.com/d9357efcc40d785828b457ce7d6a020691593e99 Cr-Commit-Position: refs/heads/master@{#407300}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/css3/masking/clip-path-reference-nonexisting-existing-local.html View 1 chunk +18 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/css3/masking/clip-path-reference-nonexisting-existing-local-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (8 generated)
fs
4 years, 5 months ago (2016-07-22 16:09:42 UTC) #5
Stephen Chennney
I'm uncomfortable with a test that is expected to not find the right reference in ...
4 years, 5 months ago (2016-07-22 16:45:45 UTC) #8
fs
On 2016/07/22 at 16:45:45, schenney wrote: > I'm uncomfortable with a test that is expected ...
4 years, 5 months ago (2016-07-22 17:27:17 UTC) #9
Stephen Chennney
On 2016/07/22 17:27:17, fs wrote: > On 2016/07/22 at 16:45:45, schenney wrote: > > I'm ...
4 years, 5 months ago (2016-07-22 17:43:28 UTC) #10
fs
On 2016/07/22 at 17:43:28, schenney wrote: > On 2016/07/22 17:27:17, fs wrote: > > On ...
4 years, 5 months ago (2016-07-22 17:47:18 UTC) #11
Stephen Chennney
> What do you mean by "reference image" above? Sorry, I should have said "expected ...
4 years, 5 months ago (2016-07-22 18:24:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174813003/1
4 years, 5 months ago (2016-07-22 23:35:00 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 23:38:57 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 23:40:35 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9357efcc40d785828b457ce7d6a020691593e99
Cr-Commit-Position: refs/heads/master@{#407300}

Powered by Google App Engine
This is Rietveld 408576698