Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2174813002: RTCPeerConnection.getStats overloads test CL (Closed)

Created:
4 years, 5 months ago by hbos_chromium
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, haraken, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RTCPeerConnection.getStats overloads test CL Launch with --enable-blink-features=RTCPeerConnectionNewGetStats Test .html: <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> <html> <head> </head> <body> <script> var pc = new webkitRTCPeerConnection(null); var selector = null; getUserMedia({audio:true, video:true}, gotStream); var handler = { handleEvent:function(x) { console.log('handler.handleEvent(' + x + ')'); } }; function func(x) { console.log('func(' + x + ')'); } function getUserMedia(dictionary, callback) { try { navigator.webkitGetUserMedia(dictionary, callback, error); } catch (e) { error(e); } } function error(e) { console.log('Error: ' + e); } function gotStream(s) { console.log('Got a stream.'); stream = s; pc.addStream(stream); selector = pc.getLocalStreams()[0].getVideoTracks()[0]; console.log('getStats(handler)'); pc.getStats(handler); console.log('getStats(func)'); pc.getStats(func); console.log('getStats(selector)'); pc.getStats(selector); } </script> </body> </html>

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -179 lines) Patch
A third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-getStats-promise.html View 1 chunk +57 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/modules/peerconnection/RTCLegacyStatsReport.h View 4 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/modules/peerconnection/RTCLegacyStatsReport.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/modules/peerconnection/RTCLegacyStatsReport.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp View 3 chunks +19 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl View 1 chunk +3 lines, -1 line 0 comments Download
D third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.h View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.cpp View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.idl View 1 chunk +0 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
hbos_chromium
4 years, 4 months ago (2016-07-27 12:12:06 UTC) #1 
Description was changed from

==========
RTCPeerConnection.getStats overloads test CL

Launch with --enable-blink-features=RTCPeerConnectionNewGetStats

Test .html:
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
</head>
<body>
<script>
var pc = new webkitRTCPeerConnection(null);
var selector = null;
getUserMedia({audio:true, video:true}, gotStream);

var handler = {
    handleEvent:function(x) {
        console.log('handler.handleEvent(' + x + ')');
    }
};

function func(x) {
    console.log('func(' + x + ')');
}

function getUserMedia(dictionary, callback) {
    try {
        navigator.webkitGetUserMedia(dictionary, callback, error);
    } catch (e) {
        error(e);
    }
}
function error(e) {
    console.log('Error: ' + e);
}

function gotStream(s) {
    console.log('Got a stream.');

    stream = s;
    pc.addStream(stream);

    selector = pc.getLocalStreams()[0].getVideoTracks()[0];

    console.log('getStats(handler)');
    pc.getStats(handler);

    console.log('getStats(func)');
    pc.getStats(func);

    console.log('getStats(selector)');
    pc.getStats(selector);
}
</script>
</body>
</html>
==========

to

==========
RTCPeerConnection.getStats overloads test CL

Launch with --enable-blink-features=RTCPeerConnectionNewGetStats

Test .html:
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
</head>
<body>
<script>
var pc = new webkitRTCPeerConnection(null);
var selector = null;
getUserMedia({audio:true, video:true}, gotStream);

var handler = {
    handleEvent:function(x) {
        console.log('handler.handleEvent(' + x + ')');
    }
};

function func(x) {
    console.log('func(' + x + ')');
}

function getUserMedia(dictionary, callback) {
    try {
        navigator.webkitGetUserMedia(dictionary, callback, error);
    } catch (e) {
        error(e);
    }
}
function error(e) {
    console.log('Error: ' + e);
}

function gotStream(s) {
    console.log('Got a stream.');

    stream = s;
    pc.addStream(stream);

    selector = pc.getLocalStreams()[0].getVideoTracks()[0];

    console.log('getStats(handler)');
    pc.getStats(handler);

    console.log('getStats(func)');
    pc.getStats(func);

    console.log('getStats(selector)');
    pc.getStats(selector);
}
</script>
</body>
</html>
==========

Powered by Google App Engine
This is Rietveld 408576698