Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2174803002: [turbolizer] Add support for showing perf profiling information. (Closed)

Created:
4 years, 5 months ago by alegil02
Modified:
4 years, 4 months ago
Reviewers:
danno, alegil02
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbolizer] Add support for showing perf profiling information. perf-turbo.py merges a perf data file and a turbofan trace file into a single json object which can then be piped to a file and uploaded to turbolizer to display the profiling data in the disassembly. With the changes, turbolizer now shows the event counts for instruction in percentage form and with heatmap-stype colouring. Multiple different events can be recorded at once with a new drop-down menu to select which event to view the counts of. The documentation has been updated with instructions. Using the script is optional and turbolizer retains previous functionality if a trace without profiling data is uploaded. BUG=None Committed: https://crrev.com/286e2b14a51c2ffcc610c0faa78443dda5625da1 Cr-Commit-Position: refs/heads/master@{#38124}

Patch Set 1 #

Patch Set 2 : [turbolizer] Add support for showing perf profiling information. #

Total comments: 1

Patch Set 3 : [turbolizer] Add support for showing perf profiling information. #

Total comments: 1

Patch Set 4 : [turbolizer] Add support for showing perf profiling information. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -23 lines) Patch
D tools/turbolizer/README View 1 chunk +0 lines, -20 lines 0 comments Download
A tools/turbolizer/README.md View 3 1 chunk +62 lines, -0 lines 0 comments Download
M tools/turbolizer/constants.js View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/turbolizer/disassembly-view.js View 5 chunks +61 lines, -1 line 0 comments Download
M tools/turbolizer/index.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
A tools/turbolizer/perf-turbo.py View 1 3 1 chunk +56 lines, -0 lines 0 comments Download
M tools/turbolizer/turbo-visualizer.css View 1 2 3 2 chunks +22 lines, -1 line 0 comments Download
M tools/turbolizer/turbo-visualizer.js View 1 2 chunks +13 lines, -0 lines 0 comments Download
M tools/turbolizer/view.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
alegil02
4 years, 5 months ago (2016-07-22 13:07:39 UTC) #2
alegil02
On 2016/07/22 13:07:39, alegil02 wrote: Some slight formatting modifications and minor changes, along with a ...
4 years, 4 months ago (2016-07-27 10:16:59 UTC) #3
danno
Almost there... https://codereview.chromium.org/2174803002/diff/20001/tools/turbolizer/perf-turbo.py File tools/turbolizer/perf-turbo.py (right): https://codereview.chromium.org/2174803002/diff/20001/tools/turbolizer/perf-turbo.py#newcode1 tools/turbolizer/perf-turbo.py:1: # Copyright 2016 the V8 project authors. ...
4 years, 4 months ago (2016-07-27 10:40:03 UTC) #4
alegil02
Made the requested changes, PTAL.
4 years, 4 months ago (2016-07-27 10:46:20 UTC) #5
danno
lgtm with a nit. https://codereview.chromium.org/2174803002/diff/40001/tools/turbolizer/turbo-visualizer.css File tools/turbolizer/turbo-visualizer.css (right): https://codereview.chromium.org/2174803002/diff/40001/tools/turbolizer/turbo-visualizer.css#newcode285 tools/turbolizer/turbo-visualizer.css:285: nit: Please remove this stray ...
4 years, 4 months ago (2016-07-28 08:45:42 UTC) #6
alegil02
Ah probably appeared from merging style changes in other patches. Thanks.
4 years, 4 months ago (2016-07-28 09:10:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174803002/60001
4 years, 4 months ago (2016-07-28 09:10:16 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-07-28 09:39:27 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 09:42:50 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/286e2b14a51c2ffcc610c0faa78443dda5625da1
Cr-Commit-Position: refs/heads/master@{#38124}

Powered by Google App Engine
This is Rietveld 408576698