Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2174783003: [tools/perf] Use yellow for instruction text about upgrading python version in record_wpr (Closed)

Created:
4 years, 5 months ago by nednguyen
Modified:
4 years, 5 months ago
Reviewers:
petrcermak
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Use yellow for instruction text about upgrading python version in record_wpr Committed: https://crrev.com/42241b5b5bca92879925108538b1fd64da5ce613 Cr-Commit-Position: refs/heads/master@{#407164}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M tools/perf/record_wpr View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
nednguyen
4 years, 5 months ago (2016-07-22 14:16:14 UTC) #2
petrcermak
LGTM with s/upgrade/upgrading/
4 years, 5 months ago (2016-07-22 14:24:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174783003/1
4 years, 5 months ago (2016-07-22 14:25:53 UTC) #6
petrcermak
I found that I needed to explicitly install psutil to get the forwarder (used by ...
4 years, 5 months ago (2016-07-22 14:45:15 UTC) #7
nednguyen
On 2016/07/22 14:45:15, petrcermak wrote: > I found that I needed to explicitly install psutil ...
4 years, 5 months ago (2016-07-22 14:57:15 UTC) #8
petrcermak
On 2016/07/22 14:57:15, nednguyen wrote: > On 2016/07/22 14:45:15, petrcermak wrote: > > I found ...
4 years, 5 months ago (2016-07-22 15:21:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 15:24:18 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 15:25:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42241b5b5bca92879925108538b1fd64da5ce613
Cr-Commit-Position: refs/heads/master@{#407164}

Powered by Google App Engine
This is Rietveld 408576698