Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

Issue 2174773002: DevTools: add correct include dirs to protocol handler generator for V8. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py
diff --git a/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py b/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py
index c785c79b528fd162573f62dc36931c38a35cf07d..c8839141ba388b8649d6ed4bc145602fca197ec0 100644
--- a/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py
+++ b/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py
@@ -24,11 +24,18 @@ templates_dir = module_path
# In Blink, jinja2 is in chromium's third_party directory.
# Insert at 1 so at front to override system libraries, and
# after path[0] == invoking script dir
-third_party_dir = os.path.normpath(os.path.join(
+blink_third_party_dir = os.path.normpath(os.path.join(
module_path, os.pardir, os.pardir, os.pardir, os.pardir, os.pardir,
"third_party"))
-if os.path.isdir(third_party_dir):
- sys.path.insert(1, third_party_dir)
+if os.path.isdir(blink_third_party_dir):
+ sys.path.insert(1, blink_third_party_dir)
+
+# In V8, it is in third_party folder
+v8_third_party_dir = os.path.normpath(os.path.join(
+ module_path, os.pardir, os.pardir, "third_party"))
+
+if os.path.isdir(v8_third_party_dir):
+ sys.path.insert(1, v8_third_party_dir)
# In Node, it is in deps folder
deps_dir = os.path.normpath(os.path.join(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698