Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2174773002: DevTools: add correct include dirs to protocol handler generator for V8. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 4 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add correct include dirs to protocol handler generator for V8. Jinja2 and markupsafe will be pulled into v8/third_party/ via DEPS, while the protocol handler generator will be pulled into v8/platform/inspector_protocol/. In order for the protocol handler generator to work when building standalone V8, it needs to include them correctly. R=pfeldman@chromium.org BUG=580337 Committed: https://crrev.com/322f425f3406a70a1513d53c35bf55bd5c3b2165 Cr-Commit-Position: refs/heads/master@{#407582}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py View 1 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
4 years, 5 months ago (2016-07-22 11:04:18 UTC) #1
pfeldman
https://codereview.chromium.org/2174773002/diff/1/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py File third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py (right): https://codereview.chromium.org/2174773002/diff/1/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py#newcode35 third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py:35: module_path, os.pardir, os.pardir, "tools")) I don't think we are ...
4 years, 5 months ago (2016-07-22 17:07:34 UTC) #2
Yang
On 2016/07/22 17:07:34, pfeldman wrote: > https://codereview.chromium.org/2174773002/diff/1/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py > File third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py > (right): > > https://codereview.chromium.org/2174773002/diff/1/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py#newcode35 ...
4 years, 5 months ago (2016-07-25 04:55:56 UTC) #3
pfeldman
lgtm
4 years, 4 months ago (2016-07-25 17:13:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174773002/20001
4 years, 4 months ago (2016-07-25 19:02:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-25 21:25:39 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 21:28:33 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/322f425f3406a70a1513d53c35bf55bd5c3b2165
Cr-Commit-Position: refs/heads/master@{#407582}

Powered by Google App Engine
This is Rietveld 408576698