arc:Integration test for Arc package Chrome sync.

chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/sync/test/integration/sync_arc_package_helper.h"
+#include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
+#include "chrome/browser/sync/test/integration/sync_test.h"
+
+using sync_integration_test_util::AwaitCommitActivityCompletion;
+
+namespace arc {
+
+namespace {
+
+/*
+bool AllProfilesHaveSameArcPackages() {
+  return SyncArcPackageHelper::GetInstance()->AllProfilesHaveSamePackages();
+} */

[Josh Horwich, 2016/07/25 16:48:08]

Is this old code to be deleted?

[lgcheng, 2016/07/25 20:45:32]

This is a preserved method. I plan to use this for package update logic. But
this patch only handles install/uninstall. I can remove it if needed in this
patch.

[Luis Héctor Chávez, 2016/07/25 20:57:24]

Yes please. There should be zero commented-out code in the repository. (except
maybe usage examples).

[lgcheng, 2016/07/25 21:37:28]

Done.

+
+bool AllProfilesHaveSameArcPackageDetail() {

[stevenjb, 2016/07/25 16:45:08]

Details

[lgcheng, 2016/07/25 20:45:32]

Done.

+  return SyncArcPackageHelper::GetInstance()->
+      AllProfilesHaveSamePackageDetail();
+}
+
+}  // namespace
+
+
+class TwoClientArcPackageSyncTest : public SyncTest {
+ public:
+  TwoClientArcPackageSyncTest() : SyncTest(TWO_CLIENT_LEGACY),
+                                  sync_helper_(nullptr) {
+    DisableVerifier();
+  }
+
+  ~TwoClientArcPackageSyncTest() override {}
+
+  bool SetupClients() override {
+    if (!SyncTest::SetupClients())
+      return false;
+
+    // Init SyncArcPackageHelper to ensure that the arc services are initialized
+    // for each Profile.
+    sync_helper_ = SyncArcPackageHelper::GetInstance();
+    return sync_helper_ != nullptr;
+  }
+
+  void ClearUp() {
+    sync_helper_->ClearUp();
+  }
+
+  SyncArcPackageHelper* sync_helper() { return sync_helper_; }
+
+ private:
+  SyncArcPackageHelper* sync_helper_;
+
+  DISALLOW_COPY_AND_ASSIGN(TwoClientArcPackageSyncTest);
+};
+
+IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest, StartWithNoPackages) {
+  ASSERT_TRUE(SetupSync());
+
+  ASSERT_TRUE(AllProfilesHaveSameArcPackageDetail());
+
+  ClearUp();
+}
+
+IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest, StartWithSamePackages) {
+  ASSERT_TRUE(SetupClients());
+
+  constexpr int kNumPackage = 5;

[stevenjb, 2016/07/25 16:45:08]

kNumPackages

[lgcheng, 2016/07/25 20:45:32]

Done.

+  for (int i = 0; i < kNumPackage; ++i) {

[Luis Héctor Chávez, 2016/07/25 17:56:24]

Same here, s/int/size_t/

[lgcheng, 2016/07/25 20:45:32]

Done.

+    sync_helper()->InstallPackageWithIndex(GetProfile(0), i);
+    sync_helper()->InstallPackageWithIndex(GetProfile(1), i);
+  }
+
+  ASSERT_TRUE(SetupSync());
+
+  ASSERT_TRUE(AllProfilesHaveSameArcPackageDetail());
+
+  ClearUp();
+}
+
+// In this test, packages are installed before sync started. Client1 will have
+// package 0 to 4 installed while client2 has no package installed.
+IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest,
+                       OneClientHasPackagesAnotherHasNone) {
+  ASSERT_TRUE(SetupClients());
+
+  constexpr int kNumPackage = 5;
+  for (int i = 0; i < kNumPackage; ++i) {
+    sync_helper()->InstallPackageWithIndex(GetProfile(0), i);
+  }
+
+  ASSERT_FALSE(AllProfilesHaveSameArcPackageDetail());
+
+  ASSERT_TRUE(SetupSync());
+
+  ASSERT_TRUE(AllProfilesHaveSameArcPackageDetail());
+
+  ClearUp();
+}
+
+// In this test, packages are installed before sync started. Client1 will have
+// package 0 to 9 installed and client2 will have package 0 to 4 installed.
+IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest,
+                       OneClientHasPackagesAnotherHasSubSet) {
+  ASSERT_TRUE(SetupClients());
+
+  constexpr int kNumPackage = 5;
+  for (int i = 0; i < kNumPackage; ++i) {
+    sync_helper()->InstallPackageWithIndex(GetProfile(0), i);
+    sync_helper()->InstallPackageWithIndex(GetProfile(1), i);
+  }
+
+  for (int i = 0; i < kNumPackage; ++i) {
+    sync_helper()->InstallPackageWithIndex(GetProfile(0), i + kNumPackage);
+  }
+
+  ASSERT_FALSE(AllProfilesHaveSameArcPackageDetail());
+
+  ASSERT_TRUE(SetupSync());
+
+  EXPECT_TRUE(AllProfilesHaveSameArcPackageDetail());
+
+  ClearUp();
+}
+
+// In this test, packages are installed before sync started. Client1 will have
+// package 0 to 4 installed and client2 will have package 1 to 5 installed.
+IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest,
+                       StartWithDifferentPackages) {
+  ASSERT_TRUE(SetupClients());
+
+  constexpr int kNumPackage = 5;
+  constexpr int kPackageIdDiff = 1;
+  for (int i = 0; i < kNumPackage; ++i) {
+    sync_helper()->InstallPackageWithIndex(GetProfile(0), i);
+    sync_helper()->InstallPackageWithIndex(GetProfile(1), i+kPackageIdDiff);
+  }
+
+  EXPECT_FALSE(AllProfilesHaveSameArcPackageDetail());
+
+  ASSERT_TRUE(SetupSync());
+
+  EXPECT_TRUE(AllProfilesHaveSameArcPackageDetail());
+
+  ClearUp();
+}
+
+// Tests package installaton after sync started.
+IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest, Install) {
+  ASSERT_TRUE(SetupSync());
+  ASSERT_TRUE(AllProfilesHaveSameArcPackageDetail());
+
+  sync_helper()->InstallPackageWithIndex(GetProfile(0), 0);
+  ASSERT_TRUE(AwaitQuiescence());
+  EXPECT_TRUE(AllProfilesHaveSameArcPackageDetail());
+
+  ClearUp();
+}
+
+// In this test, packages are installed after sync started. Client1 installs
+// package 0 to 4 and client2 installs package 3 to 7.
+IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest, InstallDifferent) {
+  ASSERT_TRUE(SetupSync());
+  ASSERT_TRUE(AllProfilesHaveSameArcPackageDetail());
+
+  constexpr int kNumPackage = 5;
+  constexpr int kPackageIdDiff = 3;
+  for (int i = 0; i < kNumPackage; ++i) {
+    sync_helper()->InstallPackageWithIndex(GetProfile(0), i);
+    sync_helper()->InstallPackageWithIndex(GetProfile(1), i+kPackageIdDiff);
+  }
+
+  ASSERT_TRUE(AwaitQuiescence());
+  EXPECT_TRUE(AllProfilesHaveSameArcPackageDetail());
+
+  ClearUp();
+}
+
+// Installs package from one client and uninstalls from another after sync
+// started.
+IN_PROC_BROWSER_TEST_F(TwoClientArcPackageSyncTest, Uninstall) {
+  ASSERT_TRUE(SetupSync());
+  ASSERT_TRUE(AllProfilesHaveSameArcPackageDetail());
+
+  sync_helper()->InstallPackageWithIndex(GetProfile(0), 1);
+  ASSERT_TRUE(AwaitQuiescence());
+  EXPECT_TRUE(AllProfilesHaveSameArcPackageDetail());
+
+  sync_helper()->UninstallPackageWithIndex(GetProfile(1), 1);
+  EXPECT_FALSE(AllProfilesHaveSameArcPackageDetail());
+  ASSERT_TRUE(AwaitQuiescence());
+  EXPECT_TRUE(AllProfilesHaveSameArcPackageDetail());
+
+  ClearUp();
+}
+
+}  // namespace arc