Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2174753003: Avoid passing an invalid file URI to analyzer on Windows. (Closed)

Created:
4 years, 5 months ago by Bob Nystrom
Modified:
4 years, 5 months ago
Reviewers:
jakemac
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid passing an invalid file URI to analyzer on Windows. If you use dart_style's library API and call format() without a URI, it defaults to using "<unknown>" for the path. Analyzer now parses that as a file URI (as opposed to just treating it like an opaque string), and "<" isn't allowed on Windows, so the parsing fails. Instead, just pass null along to analyzer and let it handle it. R=jakemac@google.com Committed: https://github.com/dart-lang/dart_style/commit/6839ce60ff79c98f61fa837ef577c12ca852b243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M CHANGELOG.md View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/dart_formatter.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 5 months ago (2016-07-22 16:36:23 UTC) #2
jakemac
lgtm
4 years, 5 months ago (2016-07-22 16:44:38 UTC) #3
Bob Nystrom
4 years, 5 months ago (2016-07-22 17:34:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6839ce60ff79c98f61fa837ef577c12ca852b243 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698