Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: chrome/browser/ui/webui/options/startup_page_list_browsertest.js

Issue 2174743002: Revert disabled test for crbug/419370 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix the comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/startup_page_list_browsertest.js
diff --git a/chrome/browser/ui/webui/options/startup_page_list_browsertest.js b/chrome/browser/ui/webui/options/startup_page_list_browsertest.js
index 1df6e28c69b95a856c9c17a4c56a6cfe4d45bbf0..6879507438ab5a218d75d498e99e1166d036ea75 100644
--- a/chrome/browser/ui/webui/options/startup_page_list_browsertest.js
+++ b/chrome/browser/ui/webui/options/startup_page_list_browsertest.js
@@ -122,8 +122,8 @@ function createMouseEvent(type) {
return event;
}
-// Disabled due to: crbug.com/419370
-TEST_F('StartupPageListWebUITest', 'DISABLED_testDropFromOutsideSource',
+// Disable if flaky again (crbug.com/419370)
+TEST_F('StartupPageListWebUITest', 'testDropFromOutsideSource',
function() {
/** @const */ var NEW_PAGE = 'http://google.com';
@@ -137,8 +137,8 @@ TEST_F('StartupPageListWebUITest', 'DISABLED_testDropFromOutsideSource',
expectTrue(mockDropEvent.defaultPrevented);
});
-// Disabled due to: crbug.com/419370
-TEST_F('StartupPageListWebUITest', 'DISABLED_testDropToReorder', function() {
+// Disable if flaky again (crbug.com/419370)
+TEST_F('StartupPageListWebUITest', 'testDropToReorder', function() {
// TODO(dbeam): mock4js doesn't handle complex arguments well. Fix this.
this.mockHandler.expects(once()).dragDropStartupPage([0, [1].join()]);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698