Issue 217473005: Test cases for FolderHeaderView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 217473005: Test cases for FolderHeaderView. (Closed)

Created:
6 years, 9 months ago by jennyz

Modified:
6 years, 9 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Test cases for FolderHeaderView. Test the following: 1. Rename a folder name if it is a normal folder. 2. Maximum folder name length. 3. Folder name not editable for oem folder. BUG=354627 R=xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260320

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+181 lines, -7 lines)			Patch
M	ui/app_list/app_list.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/app_list/test/app_list_test_model.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	ui/app_list/test/app_list_test_model.cc	View	2 chunks	+11 lines, -1 line	0 comments	Download
M	ui/app_list/views/folder_header_view.h	View	3 chunks	+17 lines, -4 lines	0 comments	Download
M	ui/app_list/views/folder_header_view.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	ui/app_list/views/folder_header_view_delegate.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
A	ui/app_list/views/folder_header_view_unittest.cc	View	1 chunk	+136 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/217473005/1

6 years, 9 months ago (2014-03-28 23:31:57 UTC) #4

jennyz

6 years, 9 months ago (2014-03-29 00:31:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r260320 (presubmit successful).