third_party/WebKit/Source/core/style/StyleBoxData.h - Issue 2174703002: Organize public ComputedStyle methods by property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleBoxData.h

Issue 2174703002: Organize public ComputedStyle methods by property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Done Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/StyleBoxData.h

diff --git a/third_party/WebKit/Source/core/style/StyleBoxData.h b/third_party/WebKit/Source/core/style/StyleBoxData.h

index ae5b9bf11935db5bd225b027238ac808175db57e..6086d3730587d9e73b4db80e8c9e243518bd2cab 100644

--- a/third_party/WebKit/Source/core/style/StyleBoxData.h

+++ b/third_party/WebKit/Source/core/style/StyleBoxData.h

@@ -32,6 +32,9 @@

namespace blink {

+// TODO(sashab): Move this into a private class on ComputedStyle, and remove

+// all methods on it, merging them into copy/creation methods on ComputedStyle

+// instead. Keep the allocation logic, only allocating a new object if needed.

class StyleBoxData : public RefCounted<StyleBoxData> {

public:

static PassRefPtr<StyleBoxData> create() { return adoptRef(new StyleBoxData); }