Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: content/public/browser/presentation_service_delegate.h

Issue 2174693004: [Presentation API] Add support to content/ for multiple URLs per PresentationRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/presentation_service_delegate.h
diff --git a/content/public/browser/presentation_service_delegate.h b/content/public/browser/presentation_service_delegate.h
index cb1725bf763ddac7e11cd82822f1f73e194c9be0..cbe2c5f1cc9c5c64cbc46d32beb5b1cca81c4950 100644
--- a/content/public/browser/presentation_service_delegate.h
+++ b/content/public/browser/presentation_service_delegate.h
@@ -107,47 +107,50 @@ class CONTENT_EXPORT PresentationServiceDelegate {
int render_process_id,
int render_frame_id) = 0;
- // Sets the default presentation URL for frame given by |render_process_id|
+ // Sets the default presentation URLs for frame given by |render_process_id|
// and |render_frame_id|. When the default presentation is started on this
// frame, |callback| will be invoked with the corresponding
// PresentationSessionInfo object.
- // If |default_presentation_url| is empty, the default presentation URL will
+ // If |default_presentation_urls| is empty, the default presentation URLs will
// be cleared and the previously registered callback (if any) will be removed.
- virtual void SetDefaultPresentationUrl(
+ // TODO(crbug.com/632623): Use GURL instead of std::string for URLs
+ virtual void SetDefaultPresentationUrls(
int render_process_id,
int render_frame_id,
- const std::string& default_presentation_url,
+ const std::vector<std::string>& default_presentation_urls,
const PresentationSessionStartedCallback& callback) = 0;
// Starts a new presentation session. The presentation id of the session will
// be the default presentation ID if any or a generated one otherwise.
// Typically, the embedder will allow the user to select a screen to show
- // |presentation_url|.
+ // one of the |presentation_urls|.
// |render_process_id|, |render_frame_id|: ID of originating frame.
- // |presentation_url|: URL of the presentation.
+ // |presentation_urls|: Possible URLs for the presentation.
// |success_cb|: Invoked with session info, if presentation session started
// successfully.
// |error_cb|: Invoked with error reason, if presentation session did not
// start.
+ // TODO(crbug.com/632623): Use GURL instead of std::string for URLs
virtual void StartSession(
int render_process_id,
int render_frame_id,
- const std::string& presentation_url,
+ const std::vector<std::string>& presentation_urls,
const PresentationSessionStartedCallback& success_cb,
const PresentationSessionErrorCallback& error_cb) = 0;
// Joins an existing presentation session. Unlike StartSession(), this
// does not bring a screen list UI.
// |render_process_id|, |render_frame_id|: ID for originating frame.
- // |presentation_url|: URL of the presentation.
+ // |presentation_urls|: Possible URLs of the presentation.
// |presentation_id|: The ID of the presentation to join.
// |success_cb|: Invoked with session info, if presentation session joined
// successfully.
// |error_cb|: Invoked with error reason, if joining failed.
+ // TODO(crbug.com/632623): Use GURL instead of std::string for URLs
virtual void JoinSession(
int render_process_id,
int render_frame_id,
- const std::string& presentation_url,
+ const std::vector<std::string>& presentation_urls,
const std::string& presentation_id,
const PresentationSessionStartedCallback& success_cb,
const PresentationSessionErrorCallback& error_cb) = 0;

Powered by Google App Engine
This is Rietveld 408576698