content/browser/presentation/presentation_type_converters.h - Issue 2174693004: [Presentation API] Add support to content/ for multiple URLs per PresentationRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/presentation/presentation_type_converters.h

Issue 2174693004: [Presentation API] Add support to content/ for multiple URLs per PresentationRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/presentation/presentation_service_impl_unittest.cc ('k') | content/browser/presentation/presentation_type_converters_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/presentation/presentation_type_converters.h

diff --git a/content/browser/presentation/presentation_type_converters.h b/content/browser/presentation/presentation_type_converters.h

index 9285dfae09ebb676389ee65fdfc7c1fee6c132c6..5a3bfb601fc9ca911e69a5e7e3a332827d7c5f0e 100644

--- a/content/browser/presentation/presentation_type_converters.h

+++ b/content/browser/presentation/presentation_type_converters.h

@@ -31,7 +31,8 @@ struct TypeConverter<blink::mojom::PresentationSessionInfoPtr,

const content::PresentationSessionInfo& input) {

blink::mojom::PresentationSessionInfoPtr output(

blink::mojom::PresentationSessionInfo::New());

- output->url = input.presentation_url;

+ // TODO(crbug.com/632623): Convert downstream APIs to use GURL

+ output->url = GURL(input.presentation_url);

output->id = input.presentation_id;

return output;

}

@@ -42,7 +43,8 @@ struct TypeConverter<content::PresentationSessionInfo,

blink::mojom::PresentationSessionInfoPtr> {

static content::PresentationSessionInfo Convert(

const blink::mojom::PresentationSessionInfoPtr& input) {

- return content::PresentationSessionInfo(input->url, input->id);

+ // TODO(crbug.com/632623): Convert downstream APIs to use GURL

+ return content::PresentationSessionInfo(input->url.spec(), input->id);

}

};