third_party/WebKit/Source/modules/presentation/PresentationController.cpp - Issue 2174693004: [Presentation API] Add support to content/ for multiple URLs per PresentationRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationController.cpp

Issue 2174693004: [Presentation API] Add support to content/ for multiple URLs per PresentationRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing TODO Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/presentation/presentation_dispatcher.cc ('k') | third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp » ('j') | third_party/WebKit/public/platform/modules/presentation/presentation.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationController.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationController.cpp b/third_party/WebKit/Source/modules/presentation/PresentationController.cpp

index 50c9ffe11a521744f7d32d63f3a0e44f93e28183..17e036671b072ffc7fbfec90e2efb6dca572277e 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationController.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationController.cpp

@@ -120,10 +120,12 @@ void PresentationController::setDefaultRequestUrl(const KURL& url)

if (!m_client)

return;

+ // TODO(crbug.com/627655): Accept multiple URLs per PresentationRequest.

+ WebVector<WebString> presentationUrls(static_cast<size_t>(1));

if (url.isValid())

- m_client->setDefaultPresentationUrl(url.getString());

- else

- m_client->setDefaultPresentationUrl(blink::WebString());

+ presentationUrls[0] = url.getString();

+ m_client->setDefaultPresentationUrls(presentationUrls);

}

void PresentationController::registerConnection(PresentationConnection* connection)