Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2174693002: Remove the unnecessary DCHECK(..), which is guranteed to be true by the previous line (Closed)

Created:
4 years, 5 months ago by hayato
Modified:
4 years, 5 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the unnecessary DCHECK(..), which is guaranteed to be true by the previous line This DCHECK just rephrases the result of the previous line. BUG=630141 Committed: https://crrev.com/119fe0f585d87fd4d86bc4765e3b947ce3fa93b2 Cr-Commit-Position: refs/heads/master@{#407104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
hayato
PTAL
4 years, 5 months ago (2016-07-22 07:29:51 UTC) #4
kochi
lgtm IN the description, 'reprase' is 'rephrase'?
4 years, 5 months ago (2016-07-22 07:45:45 UTC) #5
hayato
On 2016/07/22 at 07:45:45, kochi wrote: > lgtm > > IN the description, 'reprase' is ...
4 years, 5 months ago (2016-07-22 08:40:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174693002/1
4 years, 5 months ago (2016-07-22 08:40:41 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 08:51:25 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 08:53:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/119fe0f585d87fd4d86bc4765e3b947ce3fa93b2
Cr-Commit-Position: refs/heads/master@{#407104}

Powered by Google App Engine
This is Rietveld 408576698