Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 2174633003: Queued wheel events should not use ScopedInputScaleDisabler. (Closed)

Created:
4 years, 5 months ago by wjmaclean
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Queued wheel events should not use ScopedInputScaleDisabler. Since WebMouseWheelEvents returned by BrowserPlugin are sent to the guest's RenderWidgetHostImpl, which queues them and (may) send them later, they should have the device_scale_factor explicitly removed, as RenderWidgetHostImpl/InputRouterImpl may re-add it before sending. BUG=601875 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2164673002 Cr-Commit-Position: refs/heads/master@{#406417} (cherry picked from commit 288a99fe15afb1dfefbe253aaa3a5de3c249d866) Committed: https://chromium.googlesource.com/chromium/src/+/c3126c7e2d32256f33087c329600bb01b48be7fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wjmaclean
4 years, 5 months ago (2016-07-22 13:04:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c3126c7e2d32256f33087c329600bb01b48be7fe.

Powered by Google App Engine
This is Rietveld 408576698