scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json - Issue 2174623003: Revert of [Android] Use --use-su w/ asan_device_setup.sh.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json

Issue 2174623003: Revert of [Android] Use --use-su w/ asan_device_setup.sh. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroidASan_tester.json ('k') | scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json

diff --git a/scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json b/scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json

index fc759641804defd04e36630e40b50dffba7288f2..8c1340117ef9883e18ef747c615c917ad428ada2 100644

--- a/scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json

+++ b/scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json

@@ -534,8 +534,7 @@

"--lib",

"[SLAVE_BUILD]/src/third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/linux/libclang_rt.asan-arm-android.so",

"--device",

- "07a00ca4",

- "--use-su"

+ "07a00ca4"

"env": {

"ADB": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools/adb",

@@ -731,8 +730,7 @@

"[SLAVE_BUILD]/src/tools/android/asan/third_party/asan_device_setup.sh",