Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2174623003: Revert of [Android] Use --use-su w/ asan_device_setup.sh. (Closed)

Created:
4 years, 5 months ago by jbudorick
Modified:
4 years, 5 months ago
Reviewers:
martiniss, xunjieli
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of [Android] Use --use-su w/ asan_device_setup.sh. (patchset #1 id:1 of https://codereview.chromium.org/2169263005/ ) Reason for revert: su -c echo foo can't find echo. Original issue's description: > [Android] Use --use-su w/ asan_device_setup.sh. > > This should prevent the script from calling `adb root`, which can result in > temporary connection issues immediately after it returns. > > BUG=630639 > TBR=martiniss@chromium.org,xunjieli@chromium.org > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/d586d110fcce4de95de41660b820d624835aa8e0 TBR=martiniss@chromium.org,xunjieli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630639 Committed: https://chromium.googlesource.com/chromium/tools/build/+/067206029b23000d0576571967a142e01a587a97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroidASan_tester.json View 2 chunks +2 lines, -4 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json View 2 chunks +2 lines, -4 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jbudorick
Created Revert of [Android] Use --use-su w/ asan_device_setup.sh.
4 years, 5 months ago (2016-07-22 17:33:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174623003/1
4 years, 5 months ago (2016-07-22 17:33:36 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 17:33:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/067206029b23000d0576...

Powered by Google App Engine
This is Rietveld 408576698