|
|
Chromium Code Reviews
Description[Constrained Web Dialogs] [Cocoa] Enable autoresizing immediately if intended.
Follow up to crbug/609863.
Constrained dialogs should always be 1) fixed size or 2) autoresizing during their lifetime, not switching between one or the other.
Previously, autoresizing was done at DocumentOnLoadCompletedInMainFrame() rather than in the constructor, which caused a race condition in CrOS. This change will keep implementations consistent across desktop platforms.
BUG=630449
Committed: https://crrev.com/52adac07902f533a2dcd860eee19ae47fb6c548c
Cr-Commit-Position: refs/heads/master@{#407672}
Patch Set 1 #
Messages
Total messages: 21 (12 generated)
The CQ bit was checked by apacible@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== autosize BUG= ========== to ========== [Constrained Web Dialogs] [Cocoa] Enable autoresizing immediately if intended. BUG=630449 ==========
Description was changed from ========== [Constrained Web Dialogs] [Cocoa] Enable autoresizing immediately if intended. BUG=630449 ========== to ========== [Constrained Web Dialogs] [Cocoa] Enable autoresizing immediately if intended. Follow up to crbug/609863. Constrained dialogs should always be 1) fixed size or 2) autoresizing during their lifetime, not switching between one or the other. Previously, autoresizing was done at DocumentOnLoadCompletedInMainFrame() rather than in the constructor, which caused a race condition in CrOS. This change will keep implementations consistent across desktop platforms. BUG=630449 ==========
apacible@chromium.org changed reviewers: + ccameron@chromium.org
PTAL, thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
friendly ping!
lgtm, sorry for the delay
Thanks!
The CQ bit was checked by apacible@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by apacible@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Constrained Web Dialogs] [Cocoa] Enable autoresizing immediately if intended. Follow up to crbug/609863. Constrained dialogs should always be 1) fixed size or 2) autoresizing during their lifetime, not switching between one or the other. Previously, autoresizing was done at DocumentOnLoadCompletedInMainFrame() rather than in the constructor, which caused a race condition in CrOS. This change will keep implementations consistent across desktop platforms. BUG=630449 ========== to ========== [Constrained Web Dialogs] [Cocoa] Enable autoresizing immediately if intended. Follow up to crbug/609863. Constrained dialogs should always be 1) fixed size or 2) autoresizing during their lifetime, not switching between one or the other. Previously, autoresizing was done at DocumentOnLoadCompletedInMainFrame() rather than in the constructor, which caused a race condition in CrOS. This change will keep implementations consistent across desktop platforms. BUG=630449 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Constrained Web Dialogs] [Cocoa] Enable autoresizing immediately if intended. Follow up to crbug/609863. Constrained dialogs should always be 1) fixed size or 2) autoresizing during their lifetime, not switching between one or the other. Previously, autoresizing was done at DocumentOnLoadCompletedInMainFrame() rather than in the constructor, which caused a race condition in CrOS. This change will keep implementations consistent across desktop platforms. BUG=630449 ========== to ========== [Constrained Web Dialogs] [Cocoa] Enable autoresizing immediately if intended. Follow up to crbug/609863. Constrained dialogs should always be 1) fixed size or 2) autoresizing during their lifetime, not switching between one or the other. Previously, autoresizing was done at DocumentOnLoadCompletedInMainFrame() rather than in the constructor, which caused a race condition in CrOS. This change will keep implementations consistent across desktop platforms. BUG=630449 Committed: https://crrev.com/52adac07902f533a2dcd860eee19ae47fb6c548c Cr-Commit-Position: refs/heads/master@{#407672} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/52adac07902f533a2dcd860eee19ae47fb6c548c Cr-Commit-Position: refs/heads/master@{#407672} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
