Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2174573002: [Constrained Web Dialogs] [Cocoa] Enable autoresizing immediately if intended. (Closed)

Created:
4 years, 5 months ago by apacible
Modified:
4 years, 5 months ago
Reviewers:
ccameron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Constrained Web Dialogs] [Cocoa] Enable autoresizing immediately if intended. Follow up to crbug/609863. Constrained dialogs should always be 1) fixed size or 2) autoresizing during their lifetime, not switching between one or the other. Previously, autoresizing was done at DocumentOnLoadCompletedInMainFrame() rather than in the constructor, which caused a race condition in CrOS. This change will keep implementations consistent across desktop platforms. BUG=630449 Committed: https://crrev.com/52adac07902f533a2dcd860eee19ae47fb6c548c Cr-Commit-Position: refs/heads/master@{#407672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
apacible
PTAL, thanks!
4 years, 5 months ago (2016-07-21 23:31:57 UTC) #6
apacible
friendly ping!
4 years, 5 months ago (2016-07-25 22:10:00 UTC) #9
ccameron
lgtm, sorry for the delay
4 years, 5 months ago (2016-07-25 22:14:58 UTC) #10
apacible
Thanks!
4 years, 5 months ago (2016-07-25 22:45:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174573002/1
4 years, 5 months ago (2016-07-25 22:45:41 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/268706)
4 years, 5 months ago (2016-07-26 00:03:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174573002/1
4 years, 5 months ago (2016-07-26 00:41:12 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-26 01:21:37 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-26 01:24:28 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52adac07902f533a2dcd860eee19ae47fb6c548c
Cr-Commit-Position: refs/heads/master@{#407672}

Powered by Google App Engine
This is Rietveld 408576698