Clear all preloads when document is detached

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 2207 matching lines @@
     frameHost()->eventHandlerRegistry().documentDetached(*this);
 
     m_frame->selection().documentDetached(*this);
     m_frame->inputMethodController().documentDetached();
 
     // If this Document is associated with a live DocumentLoader, the
     // DocumentLoader will take care of clearing the FetchContext. Deferring
     // to the DocumentLoader when possible also prevents prematurely clearing
     // the context in the case where multiple Documents end up associated with
     // a single DocumentLoader (e.g., navigating to a javascript: url).
-    if (!loader())
+    if (!loader()) {
+        m_fetcher->clearPreloads(ResourceFetcher::ClearAllPreloads);

[Charlie Harrison, 2016/08/04 18:10:26]

tentative: can we do this in clearContext()?

[Yoav Weiss, 2016/08/04 20:26:14]

sure. moved

         m_fetcher->clearContext();
+    }
     // If this document is the master for an HTMLImportsController, sever that
     // relationship. This ensures that we don't leave import loads in flight,
     // thinking they should have access to a valid frame when they don't.
     if (m_importsController) {
         m_importsController->dispose();
         setImportsController(nullptr);
     }
 
     m_timers.setTimerTaskRunner(
         Platform::current()->currentThread()->scheduler()->timerTaskRunner()->clone());
@@ skipping 3794 matching lines @@
 }
 
 void showLiveDocumentInstances()
 {
     WeakDocumentSet& set = liveDocumentSet();
     fprintf(stderr, "There are %u documents currently alive:\n", set.size());
     for (Document* document : set)
         fprintf(stderr, "- Document %p URL: %s\n", document, document->url().getString().utf8().data());
 }
 #endif