telemetry/telemetry/value/trace.py - Issue 2174543002: Optimize JSON dump in telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/value/trace.py

Issue 2174543002: Optimize JSON dump in telemetry. (Closed) Base URL: git@github.com:catapult-project/catapult@master

Patch Set: add comment Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/value/trace.py

diff --git a/telemetry/telemetry/value/trace.py b/telemetry/telemetry/value/trace.py

index df2113bf17d4d2414deef5495d8104b923b8e0eb..1104ce9a8ecc2005bc9a9d95629e6bc845f44380 100644

--- a/telemetry/telemetry/value/trace.py

+++ b/telemetry/telemetry/value/trace.py

@@ -49,7 +49,9 @@ class TraceValue(value_module.Value):

if isinstance(trace, basestring):

fp.write(trace)

elif isinstance(trace, dict) or isinstance(trace, list):

- json.dump(trace, fp)

+ # Creating the string using dumps and then writing it is

+ # ~5x faster than using json.dump().

nednguyen 2016/07/22 22:56:16 Event better if we never keep the dict/list form i

+ fp.write(json.dumps(trace))

else:

raise TypeError('Trace is of unknown type.')

« no previous file with comments | « no previous file | no next file » | no next file with comments »