Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: dashboard/dashboard/elements/dialog-container.html

Issue 2174523002: Remove animations from chart tooltip. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-rebase
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/elements/dialog-container.html
diff --git a/dashboard/dashboard/elements/dialog-container.html b/dashboard/dashboard/elements/dialog-container.html
index edface4a58eddecc723e7e27f2ce8ee04e713eb5..73c7dcb0d6451b86810f78ee542306893f79b3e3 100644
--- a/dashboard/dashboard/elements/dialog-container.html
+++ b/dashboard/dashboard/elements/dialog-container.html
@@ -4,10 +4,6 @@ Copyright 2016 The Chromium Authors. All rights reserved.
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file.
-->
-<link rel="import" href="/components/neon-animation/animations/fade-out-animation.html">
-<link rel="import" href="/components/neon-animation/animations/scale-up-animation.html">
-<link rel="import" href="/components/neon-animation/neon-animation-runner-behavior.html">
-
<dom-module id='dialog-container'>
<style>
:host {
@@ -28,10 +24,6 @@ found in the LICENSE file.
Polymer({
is: 'dialog-container',
- behaviors: [
- Polymer.NeonAnimationRunnerBehavior
- ],
-
properties: {
targetid: {
type: String,
@@ -44,33 +36,9 @@ found in the LICENSE file.
type: Boolean,
value: false,
},
- animationConfig: {
- type: Object,
- value: function() {
- return {
- 'show': [{
- name: 'fade-in-animation',
- node: this,
- }],
- 'hide': [{
- name: 'fade-out-animation',
- node: this,
- }],
- };
- }
- },
},
- listeners: {
- 'neon-animation-finish': '_onAnimationFinish'
- },
- _onAnimationFinish: function() {
- if (!this.opened) {
- this.style.visibility = 'hidden';
- } else {
- this.style.visibility = 'visible';
- }
- },
+ // TODO(aiolos): Add animation on open/close.
updatePositionFromCoords: function(top, left) {
if (!this.positionisfixed) {
@@ -86,12 +54,11 @@ found in the LICENSE file.
open: function() {
this.opened = true;
this.style.visibility = 'visible';
- this.playAnimation('show');
},
close: function() {
this.opened = false;
- this.playAnimation('hide');
+ this.style.visibility = 'hidden';
},
});
</script>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698