Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2174493004: Revert of Fix the mobile emulator to use the correct device scale when disabled. (Closed)

Created:
4 years, 5 months ago by Mark P
Modified:
4 years, 5 months ago
Reviewers:
dgozman, Bret, alph
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, devtools-reviews_chromium.org, jam, pfeldman, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix the mobile emulator to use the correct device scale when disabled. (patchset #1 id:1 of https://codereview.chromium.org/2168313002/ ) Reason for revert: Likely cause of webkit_tests unexpected_failures inspector/screen-orientation-override.html https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/67873/layout-test-results/results.html Failure appeared on many bots: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux/builds/67873 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/15157 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/21002 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/7468 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/12746 and it seems related (change to devtools, failure in "inspector") Original issue's description: > Fix the mobile emulator to use the correct device scale when disabled. > > The mobile emulator was triggering a layout before it had reapplied the > original viewport parameters when it was being disabled, which with > use-zoom-for-dsf enabled was causing the wrong viewport size to be given > to various components, like plugins and scrollbars. > > BUG=628501, 628185 > > Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f > Cr-Commit-Position: refs/heads/master@{#407294} TBR=dgozman@chromium.org,alph@chromium.org,bsep@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=628501, 628185 Committed: https://crrev.com/0585519c495685502d0b0168808193bd094a0de8 Cr-Commit-Position: refs/heads/master@{#407314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/devtools/render_widget_screen_metrics_emulator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Mark P
Created Revert of Fix the mobile emulator to use the correct device scale when disabled.
4 years, 5 months ago (2016-07-23 00:20:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174493004/1
4 years, 5 months ago (2016-07-23 00:21:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-23 00:22:03 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-23 00:24:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0585519c495685502d0b0168808193bd094a0de8
Cr-Commit-Position: refs/heads/master@{#407314}

Powered by Google App Engine
This is Rietveld 408576698