Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 217443002: Mojo: Move mojo/public/utility to mojo/public/cpp/utility. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Move mojo/public/utility to mojo/public/cpp/utility. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260324

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -1378 lines) Patch
M mojo/examples/sample_app/sample_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_public.gypi View 2 chunks +19 lines, -19 lines 0 comments Download
M mojo/public/bindings/tests/connector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/handle_passing_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/remote_ptr_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/request_response_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/router_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/tests/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/c/tests/system/core_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/cpp/tests/utility/mutex_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + mojo/public/cpp/tests/utility/run_loop_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/public/cpp/tests/utility/thread_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/cpp/utility/lib/mutex.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/cpp/utility/lib/run_loop.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/utility/lib/thread.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/cpp/utility/lib/thread_local.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/utility/lib/thread_local_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/cpp/utility/lib/thread_local_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/cpp/utility/mutex.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/utility/run_loop.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/utility/run_loop_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/utility/thread.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/environment/lib/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/environment/lib/buffer_tls.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/environment/lib/default_async_waiter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/environment/lib/environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/environment/tests/async_waiter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/utility/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/public/utility/lib/mutex.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/public/utility/lib/run_loop.cc View 1 chunk +0 lines, -224 lines 0 comments Download
D mojo/public/utility/lib/thread.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D mojo/public/utility/lib/thread_local.h View 1 chunk +0 lines, -61 lines 0 comments Download
D mojo/public/utility/lib/thread_local_posix.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/public/utility/lib/thread_local_win.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/public/utility/mutex.h View 1 chunk +0 lines, -70 lines 0 comments Download
D mojo/public/utility/run_loop.h View 1 chunk +0 lines, -108 lines 0 comments Download
D mojo/public/utility/run_loop_handler.h View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/public/utility/tests/mutex_unittest.cc View 1 chunk +0 lines, -262 lines 0 comments Download
D mojo/public/utility/tests/run_loop_unittest.cc View 1 chunk +0 lines, -194 lines 0 comments Download
D mojo/public/utility/tests/thread_unittest.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D mojo/public/utility/thread.h View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
viettrungluu
6 years, 9 months ago (2014-03-28 20:43:40 UTC) #1
sky
Rubber stamp LGTM
6 years, 9 months ago (2014-03-28 20:48:17 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-28 20:48:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/217443002/1
6 years, 9 months ago (2014-03-28 20:51:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 22:12:29 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=290628
6 years, 9 months ago (2014-03-28 22:12:29 UTC) #6
viettrungluu
6 years, 8 months ago (2014-03-29 00:39:30 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 manually as r260324 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698