Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: pkg/analyzer/test/generated/non_hint_code_test.dart

Issue 2174423005: Fix for false positive in field (not-)overriding. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/generated/non_hint_code_test.dart
diff --git a/pkg/analyzer/test/generated/non_hint_code_test.dart b/pkg/analyzer/test/generated/non_hint_code_test.dart
index ae908e0432908a1d1aa75f2a3a21bc7f870db2d5..4ec16403a176138be2b18aa73b166e5368b87f61 100644
--- a/pkg/analyzer/test/generated/non_hint_code_test.dart
+++ b/pkg/analyzer/test/generated/non_hint_code_test.dart
@@ -486,32 +486,44 @@ class A {
verify([source]);
}
- void test_overrideOnNonOverridingGetter_field_inInterface() {
+ void test_overrideOnNonOverridingField_inInterface() {
Source source = addSource(r'''
library dart.core;
const override = null;
class A {
- int get m => 0;
+ int get a => 0;
+ void set b(_) {}
+ int c;
}
class B implements A {
@override
- final int m = 1;
+ final int a = 1;
+ @override
+ int b;
+ @override
+ int c;
}''');
computeLibrarySourceErrors(source);
assertNoErrors(source);
verify([source]);
}
- void test_overrideOnNonOverridingGetter_field_inSuperclass() {
+ void test_overrideOnNonOverridingField_inSuperclass() {
Source source = addSource(r'''
library dart.core;
const override = null;
class A {
- int get m => 0;
+ int get a => 0;
+ void set b(_) {}
+ int c;
}
class B extends A {
@override
- final int m = 1;
+ final int a = 1;
+ @override
+ int b;
+ @override
+ int c;
}''');
computeLibrarySourceErrors(source);
assertNoErrors(source);

Powered by Google App Engine
This is Rietveld 408576698