Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2174363002: [build] Fix header-hygiene warnings for arm64 (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Fix header-hygiene warnings for arm64 This prepares for switching arm64 sim to gn. BUG=chromium:474921 Committed: https://crrev.com/aa32233676b0474aae30e2a8df700d94aaa96e24 Cr-Commit-Position: refs/heads/master@{#38033}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M test/cctest/test-utils-arm64.h View 2 chunks +5 lines, -1 line 1 comment Download
M test/cctest/test-utils-arm64.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2174363002/diff/1/test/cctest/test-utils-arm64.h File test/cctest/test-utils-arm64.h (left): https://codereview.chromium.org/2174363002/diff/1/test/cctest/test-utils-arm64.h#oldcode39 test/cctest/test-utils-arm64.h:39: using namespace v8::internal; https://www.chromium.org/developers/coding-style/chromium-style-checker-errors Look for header-hygiene
4 years, 5 months ago (2016-07-25 15:13:29 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-25 16:25:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174363002/1
4 years, 5 months ago (2016-07-25 18:12:38 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 18:14:19 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 18:16:37 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aa32233676b0474aae30e2a8df700d94aaa96e24
Cr-Commit-Position: refs/heads/master@{#38033}

Powered by Google App Engine
This is Rietveld 408576698