NonValidatingReload: Monitor reload operations in NavigationControllerImpl

content/browser/frame_host/navigation_controller_impl.h

Index: content/browser/frame_host/navigation_controller_impl.h
diff --git a/content/browser/frame_host/navigation_controller_impl.h b/content/browser/frame_host/navigation_controller_impl.h
index 6947ce9565f045162a675d7471f70fa24456a3ad..7d6eafd1ebdfca76f120215bb88f72d5d4e88858 100644
--- a/content/browser/frame_host/navigation_controller_impl.h
+++ b/content/browser/frame_host/navigation_controller_impl.h
@@ -448,6 +448,15 @@ class CONTENT_EXPORT NavigationControllerImpl
 
   std::unique_ptr<NavigationEntryScreenshotManager> screenshot_manager_;
 
+  // Used to track if the last navigation type is for reload operations.

[Charlie Reis, 2016/08/08 23:57:53]

We should be specific about whether this refers to the last commit.  (It could
be the last started navigation, which would have a different meaning and might
run into problems with renderer-initiated navigations.)

Might even be clearer to call it last_commit_was_reload_.

[Takashi Toyoshima, 2016/08/09 12:06:17]

This is confusing, but when NotifyNavigationEntryCommitted() is called, the last
committed entry means one for the current completing navigation. But what we
keep here is the previously finished navigation. So, previous_commit_was_reload_
would be better?

+  bool is_last_navigation_reload_;
+
+  // Used to track the last reload type.
+  ReloadType last_reload_type_;
+
+  // Used to track delta time between subsequent navigations for the main frame.
+  base::Time last_navigation_time_;

[Charlie Reis, 2016/08/08 23:57:54]

I'm wondering if this is already tracked somewhere.  Could we use GetTimestamp
from GetLastCommittedEntry?

[Takashi Toyoshima, 2016/08/09 12:06:17]

At this point, the entry is already overwritten with one of completing
navigation, and  what we want to track with this variable is one for previous
navigation.

So, we still need to have this, I think. But, using GetTimestamp looks better
than base::Time::Now().

+
   DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl);
 };