NonValidatingReload: Monitor reload operations in NavigationControllerImpl

content/browser/frame_host/navigation_entry_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
 
 #include <stdint.h>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_vector.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "content/browser/frame_host/frame_navigation_entry.h"
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/common/frame_message_enums.h"
 #include "content/common/resource_request_body_impl.h"
 #include "content/public/browser/favicon_status.h"
 #include "content/public/browser/global_request_id.h"
 #include "content/public/browser/navigation_entry.h"
+#include "content/public/browser/reload_type.h"
 #include "content/public/browser/restore_type.h"
 #include "content/public/browser/ssl_status.h"
 #include "content/public/common/page_state.h"
 
 namespace content {
 class ResourceRequestBodyImpl;
 struct CommonNavigationParams;
 struct RequestNavigationParams;
 struct StartNavigationParams;
 
@@ skipping 263 matching lines @@
   }
   bool is_renderer_initiated() const {
     return is_renderer_initiated_;
   }
 
   void set_user_typed_url(const GURL& user_typed_url) {
     user_typed_url_ = user_typed_url;
   }
 
   // The RestoreType for this entry. This is set if the entry was retored. This
-  // is set to RESTORE_NONE once the entry is loaded.
+  // is set to RestoreType::NONE once the entry is loaded.
   void set_restore_type(RestoreType type) {
     restore_type_ = type;
   }
   RestoreType restore_type() const {
     return restore_type_;
   }
 
+  void set_reload_type(ReloadType type) {

[Charlie Reis, 2016/09/19 22:23:52]

Please document these.

[Takashi Toyoshima, 2016/09/26 12:23:34]

Done.

+    reload_type_ = type;
+  }
+  ReloadType reload_type() const { return reload_type_; }
+
   void set_transferred_global_request_id(
       const GlobalRequestID& transferred_global_request_id) {
     transferred_global_request_id_ = transferred_global_request_id;
   }
 
   GlobalRequestID transferred_global_request_id() const {
     return transferred_global_request_id_;
   }
 
   // Whether this (pending) navigation needs to replace current entry.
@@ skipping 174 matching lines @@
 
 #if defined(OS_ANDROID)
   // The time at which Chrome received the Android Intent that triggered this
   // URL load operation. Reset at commit and not persisted.
   base::TimeTicks intent_received_timestamp_;
 
   // Whether the URL load carries a user gesture.
   bool has_user_gesture_;
 #endif
 
+  // Set when a reload is requested to check navigation type at commit time.

[Charlie Reis, 2016/09/19 22:23:52]

Please mention that this is ReloadType::NONE for all non-reloads, and include
the phrase "Reset at commit and not persisted."

[Takashi Toyoshima, 2016/09/26 12:23:34]

Done.

+  ReloadType reload_type_;
+
   // Used to store extra data to support browser features. This member is not
   // persisted, unless specific data is taken out/put back in at save/restore
   // time (see TabNavigation for an example of this).
   std::map<std::string, base::string16> extra_data_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationEntryImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_