third_party/WebKit/Source/core/loader/DocumentLoader.cpp - Issue 2174263002: Defer loads in new pages/frames if ScopedPageLoadDeferral is active

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/DocumentLoader.cpp

Issue 2174263002: Defer loads in new pages/frames if ScopedPageLoadDeferral is active (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make the unfortunate hack slightly less ugly. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/loader/DocumentLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/DocumentLoader.cpp b/third_party/WebKit/Source/core/loader/DocumentLoader.cpp

index 9e23b1a9187c4913ae9207a2e6136cd19addece2..9b431237967a73720f56f2faae6a0058a3b4afa8 100644

--- a/third_party/WebKit/Source/core/loader/DocumentLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/DocumentLoader.cpp

@@ -275,7 +275,9 @@ void DocumentLoader::notifyFinished(Resource* resource)

void DocumentLoader::finishedLoading(double finishTime)

{

- ASSERT(!m_frame->page()->defersLoading() || InspectorInstrumentation::isDebuggerPaused(m_frame));

+ DCHECK(m_frame->loader().stateMachine()->creatingInitialEmptyDocument()

+ || !m_frame->page()->defersLoading()

+ || InspectorInstrumentation::isDebuggerPaused(m_frame));

double responseEndTime = finishTime;

if (!responseEndTime)

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »