Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 217423018: [Password Generation] Don't generate passwords for custom passphrase users. (Closed)

Created:
6 years, 8 months ago by Garrett Casto
Modified:
6 years, 8 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Patrick Dubroy
Visibility:
Public.

Description

[Password Generation] Don't generate passwords for custom passphrase users. BUG=358998 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263156

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/password_manager/chrome_password_manager_client.cc View 1 1 chunk +6 lines, -1 line 1 comment Download

Messages

Total messages: 10 (0 generated)
Garrett Casto
6 years, 8 months ago (2014-04-02 07:40:47 UTC) #1
Garrett Casto
+zea to verify that this is the correct way to check if a user has ...
6 years, 8 months ago (2014-04-10 19:12:20 UTC) #2
Nicolas Zea
https://codereview.chromium.org/217423018/diff/1/chrome/browser/password_manager/chrome_password_manager_client.cc File chrome/browser/password_manager/chrome_password_manager_client.cc (right): https://codereview.chromium.org/217423018/diff/1/chrome/browser/password_manager/chrome_password_manager_client.cc#newcode144 chrome/browser/password_manager/chrome_password_manager_client.cc:144: !sync_service->IsPassphraseRequired()) { You should instead check !sync_service->IsUsingSecondaryPassphrase()
6 years, 8 months ago (2014-04-10 19:53:07 UTC) #3
Garrett Casto
https://codereview.chromium.org/217423018/diff/1/chrome/browser/password_manager/chrome_password_manager_client.cc File chrome/browser/password_manager/chrome_password_manager_client.cc (right): https://codereview.chromium.org/217423018/diff/1/chrome/browser/password_manager/chrome_password_manager_client.cc#newcode144 chrome/browser/password_manager/chrome_password_manager_client.cc:144: !sync_service->IsPassphraseRequired()) { On 2014/04/10 19:53:07, Nicolas Zea wrote: > ...
6 years, 8 months ago (2014-04-10 20:10:08 UTC) #4
Nicolas Zea
lgtm
6 years, 8 months ago (2014-04-10 20:13:52 UTC) #5
Garrett Casto
The CQ bit was checked by gcasto@chromium.org
6 years, 8 months ago (2014-04-10 20:43:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gcasto@chromium.org/217423018/20001
6 years, 8 months ago (2014-04-10 20:44:07 UTC) #7
commit-bot: I haz the power
Change committed as 263156
6 years, 8 months ago (2014-04-11 03:00:20 UTC) #8
Nicolas Zea
https://codereview.chromium.org/217423018/diff/20001/chrome/browser/password_manager/chrome_password_manager_client.cc File chrome/browser/password_manager/chrome_password_manager_client.cc (right): https://codereview.chromium.org/217423018/diff/20001/chrome/browser/password_manager/chrome_password_manager_client.cc#newcode143 chrome/browser/password_manager/chrome_password_manager_client.cc:143: sync_service->HasSyncSetupCompleted() && It turns out this actually also needs ...
6 years, 8 months ago (2014-04-16 17:25:31 UTC) #9
Garrett Casto
6 years, 8 months ago (2014-04-16 17:33:14 UTC) #10
Message was sent while issue was closed.
On 2014/04/16 17:25:31, Nicolas Zea wrote:
>
https://codereview.chromium.org/217423018/diff/20001/chrome/browser/password_...
> File chrome/browser/password_manager/chrome_password_manager_client.cc
(right):
> 
>
https://codereview.chromium.org/217423018/diff/20001/chrome/browser/password_...
> chrome/browser/password_manager/chrome_password_manager_client.cc:143:
> sync_service->HasSyncSetupCompleted() &&
> It turns out this actually also needs to check
sync_service->sync_initialized()
> before it checks IsUsingSecondaryPassphrase. Else the crashes we're seeing
> happen while sync is still initializing.

Yeah, I'll send out a new CL today.

Powered by Google App Engine
This is Rietveld 408576698