Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 217423015: DevTools: fix leaking CSSRules through LiveLocations (Closed)

Created:
6 years, 8 months ago by lushnikov
Modified:
6 years, 8 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: fix leaking CSSRules through LiveLocations This patch removes live location from header stylesheet on dispose action. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170578

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/devtools/front_end/CSSStyleModel.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lushnikov
6 years, 8 months ago (2014-04-01 14:43:17 UTC) #1
apavlov
lgtm
6 years, 8 months ago (2014-04-01 14:44:26 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 8 months ago (2014-04-01 14:44:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/217423015/1
6 years, 8 months ago (2014-04-01 14:45:05 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 15:56:43 UTC) #5
Message was sent while issue was closed.
Change committed as 170578

Powered by Google App Engine
This is Rietveld 408576698