Issue 217423012: Avoid the hash table StyleInvalidator::clearInvalidation in Node::detach when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 217423012: Avoid the hash table StyleInvalidator::clearInvalidation in Node::detach when possible (Closed)

Created:
6 years, 8 months ago by esprehn

Modified:
6 years, 8 months ago

Reviewers:
chrishtr, rune

CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Avoid the hash table StyleInvalidator::clearInvalidation in Node::detach when possible Accessing the hash table in every ::detach call is a lot of overhead since in the common case the Element is not even in the hash table. We should check the needsStyleInvalidation() bit first. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170539

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/css/invalidation/StyleInvalidator.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/217423012/1

6 years, 8 months ago (2014-04-01 09:17:47 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages