Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 217423011: Use %pure-parser in grammar files to make Bison 3 happy. (Closed)

Created:
6 years, 8 months ago by tsniatowski
Modified:
6 years, 8 months ago
Reviewers:
esprehn, dglazkov, eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, apavlov
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use %pure-parser in grammar files to make Bison 3 happy. This avoids a "deprecated directive, use ‘%pure-parser’ [-Wdeprecated]" warning in css/CSSGrammar.y and xml/XPathGrammar.y when building with Bison 3. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/css/CSSGrammar.y View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathGrammar.y View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tsniatowski
6 years, 8 months ago (2014-04-01 06:04:22 UTC) #1
eseidel
So long as it still works in bison 2, or whatever most folks use. Also, ...
6 years, 8 months ago (2014-04-01 06:07:04 UTC) #2
eseidel
lgtm
6 years, 8 months ago (2014-04-01 06:07:08 UTC) #3
eseidel
6 years, 8 months ago (2014-04-01 06:07:20 UTC) #4
tsniatowski
https://code.google.com/p/lilypond/issues/detail?id=3488 has some condensed info, the gist is that the dash variant still works in ...
6 years, 8 months ago (2014-04-01 06:17:17 UTC) #5
tsniatowski
The CQ bit was checked by tsniatowski@opera.com
6 years, 8 months ago (2014-04-01 06:17:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsniatowski@opera.com/217423011/1
6 years, 8 months ago (2014-04-01 06:17:32 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 07:23:00 UTC) #8
Message was sent while issue was closed.
Change committed as 170525

Powered by Google App Engine
This is Rietveld 408576698