Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 217423008: Ignore failure on more GTX660 GMs (Closed)

Created:
6 years, 8 months ago by borenet
Modified:
6 years, 8 months ago
Reviewers:
epoger, bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Ignore failure on more GTX660 GMs verttext_msaa16 megalooper_0x0_nvprmsaa4 megalooper_1x4_nvprmsaa4 BUG=skia:2354 NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13992

Patch Set 1 #

Total comments: 1

Patch Set 2 : Missing verttext_msaa16 #

Total comments: 4

Patch Set 3 : Update bug number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -38 lines) Patch
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json View 9 chunks +13 lines, -10 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json View 1 2 9 chunks +12 lines, -9 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 9 chunks +13 lines, -10 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/expected-results.json View 9 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
borenet
https://codereview.chromium.org/217423008/diff/1/expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json File expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json (right): https://codereview.chromium.org/217423008/diff/1/expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json#newcode13543 expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json:13543: "ignore-failure": true, I think I manually added these lines ...
6 years, 8 months ago (2014-03-31 15:26:05 UTC) #1
epoger
LGTM with one question https://codereview.chromium.org/217423008/diff/20001/expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json File expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json (right): https://codereview.chromium.org/217423008/diff/20001/expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json#newcode13543 expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json:13543: "ignore-failure": true, On 2014/03/31 15:26:05, ...
6 years, 8 months ago (2014-03-31 15:37:03 UTC) #2
borenet
https://codereview.chromium.org/217423008/diff/20001/expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json File expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json (right): https://codereview.chromium.org/217423008/diff/20001/expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json#newcode19652 expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json:19652: 2325 On 2014/03/31 15:37:03, epoger wrote: > Should this ...
6 years, 8 months ago (2014-03-31 16:19:37 UTC) #3
borenet
The CQ bit was checked by borenet@google.com
6 years, 8 months ago (2014-03-31 16:19:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/217423008/40001
6 years, 8 months ago (2014-03-31 16:19:49 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 16:22:29 UTC) #6
Message was sent while issue was closed. 
Change committed as 13992

Powered by Google App Engine
This is Rietveld 408576698