Source/build/scripts/make_mediaquery_tokenizer_codepoints.py - Issue 217423005: Get Media Query parser to handle parens, brackets and braces blocks correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/build/scripts/make_mediaquery_tokenizer_codepoints.py

Issue 217423005: Get Media Query parser to handle parens, brackets and braces blocks correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added more tests Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/build/scripts/make_mediaquery_tokenizer_codepoints.py

diff --git a/Source/build/scripts/make_mediaquery_tokenizer_codepoints.py b/Source/build/scripts/make_mediaquery_tokenizer_codepoints.py

index 86af6633c614b6cefa832b278e35f2fe50fc0fbf..ba5199c32a85acc8c92d0414727c5cb2fed97884 100755

--- a/Source/build/scripts/make_mediaquery_tokenizer_codepoints.py

+++ b/Source/build/scripts/make_mediaquery_tokenizer_codepoints.py

@@ -28,6 +28,10 @@ const unsigned codePointsNumber = {array_size};

def token_type(i):

codepoints = {'(': 'leftParenthesis',

')': 'rightParenthesis',

+ '[': 'leftBracket',

+ ']': 'rightBracket',

+ '{': 'leftBrace',

+ '}': 'rightBrace',

'+': 'plusOrFullStop',

'.': 'plusOrFullStop',

'-': 'hyphenMinus',

« no previous file with comments | « no previous file | Source/core/css/MediaQuerySetTest.cpp » ('j') | no next file with comments »