Source/core/css/MediaQuerySetTest.cpp - Issue 217423005: Get Media Query parser to handle parens, brackets and braces blocks correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaQuerySetTest.cpp

Issue 217423005: Get Media Query parser to handle parens, brackets and braces blocks correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed algorithm and more tests Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/build/scripts/make_mediaquery_tokenizer_codepoints.py ('k') | Source/core/css/parser/MediaQueryParser.h » ('j') | Source/core/css/parser/MediaQueryParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/MediaQuerySetTest.cpp

diff --git a/Source/core/css/MediaQuerySetTest.cpp b/Source/core/css/MediaQuerySetTest.cpp

index ef8178cf59cc3d05e32dcb0e72c3e4c59e4f4b98..a594a060bcd3ce51805f193da48b57a37d9b5474 100644

--- a/Source/core/css/MediaQuerySetTest.cpp

+++ b/Source/core/css/MediaQuerySetTest.cpp

@@ -97,6 +97,25 @@ TEST(MediaQueryParserTest, Basic)

{"all and (orientation:landscape)", "(orientation: landscape)"},

{"NOT braille, tv AND (max-width: 200px) and (min-WIDTH: 100px) and (orientation: landscape), (color)",

"not braille, tv and (max-width: 200px) and (min-width: 100px) and (orientation: landscape), (color)"},

+ {"(max-width: 700px), (max-width: 700px)", "(max-width: 700px), (max-width: 700px)"},

+ {"(max-width: 800px()), (max-width: 800px)", "not all, (max-width: 800px)"},

+ {"(max-width: 900px(()), (max-width: 900px)", "not all"},

+ {"(max-width: 600px(())))), (max-width: 600px)", "not all, (max-width: 600px)"},

+ {"(max-width: 500px(((((((((())))), (max-width: 500px)", "not all"},

+ {"(max-width: 800px[]), (max-width: 800px)", "not all, (max-width: 800px)"},

+ {"(max-width: 900px[[]), (max-width: 900px)", "not all"},

+ {"(max-width: 600px[[]]]]), (max-width: 600px)", "not all, (max-width: 600px)"},

+ {"(max-width: 500px[[[[[[[[[[]]]]), (max-width: 500px)", "not all"},

+ {"(max-width: 800px{}), (max-width: 800px)", "not all, (max-width: 800px)"},

+ {"(max-width: 900px{{}), (max-width: 900px)", "not all"},

+ {"(max-width: 600px{{}}}}), (max-width: 600px)", "not all, (max-width: 600px)"},

+ {"(max-width: 500px{{{{{{{{{{}}}}), (max-width: 500px)", "not all"},

+ {"[(), (max-width: 900px)", "not all"},

+ {"[{}, (max-width: 900px)", "not all"},

+ {"[{]}], (max-width: 900px)", "not all, (max-width: 900px)"},

+ {"[{[]{}{{{}}}}], (max-width: 900px)", "not all, (max-width: 900px)"},

+ {"[{[}], (max-width: 900px)", "not all"},

+ {"[({)}], (max-width: 900px)", "not all"},

{0, 0} // Do not remove the terminator line.

};