Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 217423002: Removes Experimental hotword-always-on feature. (Closed)

Created:
6 years, 9 months ago by Jun Mukai
Modified:
6 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, arv+watch_chromium.org
Visibility:
Public.

Description

Removes Experimental hotword-always-on feature. It was added for some experiments, but it's over. We don't need this flag anymore. Even when we really want to do this in the future, the code base would be quite different and this would not be reused. BUG=None TBR=xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261518

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -707 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/resources/app_list/speech_manager.js View 1 3 chunks +6 lines, -29 lines 0 comments Download
M chrome/browser/resources/app_list/start_page.js View 2 chunks +0 lines, -16 lines 0 comments Download
D chrome/browser/ui/app_list/hotword_background_activity_delegate.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/ui/app_list/hotword_background_activity_monitor.h View 1 chunk +0 lines, -104 lines 0 comments Download
D chrome/browser/ui/app_list/hotword_background_activity_monitor.cc View 1 chunk +0 lines, -180 lines 0 comments Download
D chrome/browser/ui/app_list/hotword_background_activity_monitor_unittest.cc View 1 chunk +0 lines, -235 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 2 chunks +4 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/app_list/start_page_handler.h View 4 chunks +1 line, -16 lines 0 comments Download
M chrome/browser/ui/webui/app_list/start_page_handler.cc View 8 chunks +4 lines, -54 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/app_list_switches.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/app_list_switches.cc View 1 2 chunks +0 lines, -13 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 9 months ago (2014-03-28 20:53:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/217423002/1
6 years, 9 months ago (2014-03-28 20:55:36 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 00:44:52 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-29 00:44:52 UTC) #4
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 9 months ago (2014-03-29 00:56:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/217423002/1
6 years, 9 months ago (2014-03-29 00:57:33 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 02:30:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 02:30:17 UTC) #8
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 8 months ago (2014-03-31 17:15:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/217423002/1
6 years, 8 months ago (2014-03-31 17:18:28 UTC) #10
Jun Mukai
The CQ bit was unchecked by mukai@chromium.org
6 years, 8 months ago (2014-03-31 18:00:56 UTC) #11
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 8 months ago (2014-04-02 17:40:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/217423002/1
6 years, 8 months ago (2014-04-02 17:41:02 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 00:52:22 UTC) #14
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=60743
6 years, 8 months ago (2014-04-03 00:52:23 UTC) #15
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 8 months ago (2014-04-03 17:08:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/217423002/1
6 years, 8 months ago (2014-04-03 17:08:26 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 17:08:36 UTC) #18
commit-bot: I haz the power
Failed to apply patch for ui/app_list/app_list_switches.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-03 17:08:36 UTC) #19
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 8 months ago (2014-04-03 17:13:31 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/217423002/20001
6 years, 8 months ago (2014-04-03 17:14:09 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 20:26:06 UTC) #22
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 20:26:07 UTC) #23
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 8 months ago (2014-04-03 20:37:22 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/217423002/20001
6 years, 8 months ago (2014-04-03 20:37:27 UTC) #25
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 20:39:30 UTC) #26
Message was sent while issue was closed.
Change committed as 261518

Powered by Google App Engine
This is Rietveld 408576698